Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides of Writable fields are undone by first update notification from Consul #72

Closed
lenny-goodell opened this issue Apr 24, 2020 · 1 comment
Assignees
Labels
3-high priority denoting release-blocking issues bug Something isn't working geneva

Comments

@lenny-goodell
Copy link
Member

On startup we have always received an initial update notification from consul when nothing actually changed in consul. Previously when Consul was the Record of True this was not an issue.

Now it is an issue as overrides to Writable fields, which applied after loading from Consul, are undone when this initial update notification is processed. This only occurs when config already exists in Consul and a Writable filed that has an override has been changed in Consul or the override was added after to config was pushed into Consul

We somehow need to ignore this first bogus update notification from Consul.

@lenny-goodell lenny-goodell added bug Something isn't working 3-high priority denoting release-blocking issues geneva labels Apr 24, 2020
@lenny-goodell lenny-goodell self-assigned this Apr 24, 2020
lenny-goodell referenced this issue in lenny-goodell/go-mod-bootstrap Apr 25, 2020
First notification doesn't actual have any changes, but causes issues with
overrides that might have just been applied.

closes #72

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell
Copy link
Member Author

Do the following to recreate this issue:

  1. Stop edgex stack if running & Prune docker the volumes
  2. Pull latest images
  3. Start up the EdgeX stack (i.e. mongo-no-sect)
  4. Verify data is flowing from device virtual by view logs for Core Data.
  5. View logs for app-service-configurable-rules and see events are not being logged with level INFO
  6. Edit compose file and add Writable_LogLevel: DEBUG to app-service-configurable-rules environment section
  7. Restart app-service-configurable-rules
  8. View logs for app-service-configurable-rules and see events are STILL not being logged since level is still INFO, but you do see override logged
'Writable.LogLevel' by environment variable: Writable_LogLevel=DEBUG"

lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Apr 30, 2020
brandonforster pushed a commit to edgexfoundry/edgex-go that referenced this issue Apr 30, 2020
…e. (#2536)

Fixes this issue edgexfoundry/go-mod-bootstrap#72

closes #2535

Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell pushed a commit to lenny-goodell/device-sdk-go that referenced this issue Apr 30, 2020
Fixes this issue edgexfoundry/go-mod-bootstrap#72

closes #518

Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues bug Something isn't working geneva
Projects
None yet
Development

No branches or pull requests

1 participant