-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implemention of openziti to go-mod-bootstrap #659
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a7d006c
feat: add openziti/zero trust to go-mod-bootstrap. resolve conflicts
dovholuknf abf5491
fix: address test failure
dovholuknf 96f5c72
fix: address PR comment. also restore HttpTransportFromService which …
dovholuknf 75426c4
fix: address cyclical compilaiton issue from edgex-go
dovholuknf a098b41
fix: address failing test. remove unneeded nil check after solving th…
dovholuknf 929ef1f
fix: no need for the debug variable after figuring out the issue
dovholuknf 25dd8a7
fix: add zero trust flag to secret provider. regen mock. adapt code
dovholuknf 36daeb5
fix: continued PR feedback/refinement
dovholuknf af1cb36
fix: rearrange imports to minimize changes
dovholuknf 4b92d54
fix: didn't push the rename changes. remove the HandleOpenZiti functi…
dovholuknf 42049ab
fix: go test ./... succeeds but make test fails?
dovholuknf d73bf1c
fix: use struct as key for context
dovholuknf 9f9a216
fix: address pr comments.
dovholuknf 96197b9
fix: use constants and tweak log message
dovholuknf 173b050
fix: use 3.2.0-dev.13
dovholuknf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dovholuknf I'm refactoring your code for #789. I'm confused about the purpose of local
zc
variable. It looks to me that the code only assigns&zitiCtx
tozc.c
here without any further processing. Do we really need to keepzc
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I see, it appears to be totally vestigal. I don't find any references to it whatsoever other than this one line. I expect at one point a function was defined on the struct, the function removed, leaving this behind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reply. I'll remove both this variable and ZitiContext struct in my PR.