Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add validation tag to verify subscription with empty Channels #566

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

weichou1229
Copy link
Member

Close #565

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #565

What is the new behavior?

Add validation tag gt=0 to verify subscription:

  • empty Channels should be invalid
  • nil Channels should be valid

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Add validation tag `gt=0` to verify subscription:
- empty Channels should be invalid
- nil Channels should be valid

Close edgexfoundry#565

Signed-off-by: weichou <weichou1229@gmail.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2 notifications] PATCH subscription with empty Channels should be invalid
2 participants