Crash diff server when its process pool dies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server's process pool (used for actually running the diffs) fails repeatedly, assume it just can't be started and crash the whole server so a process manager can clean things up and totally start over. You can retain the old behavior (where the server keeps trying to start a new process pool if the old one is broken) by setting the `RESTART_BROKEN_DIFFER` environment variable to `true`.
Mr0grog
force-pushed
the
42-crash-in-a-blaze-of-glory-when-process-pool-dies
branch
from
27e83e8 to
8e79ece
Compare
Mr0grog
deleted the
42-crash-in-a-blaze-of-glory-when-process-pool-dies
branch
Mr0grog
restored the
42-crash-in-a-blaze-of-glory-when-process-pool-dies
branch
Mr0grog
deleted the
42-crash-in-a-blaze-of-glory-when-process-pool-dies
branch
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Jan 1, 2021
This is a test of edgi-govdata-archiving/web-monitoring-diff#49. We want this to run for a few days and make sure there aren't stability problems. If there are, we'll flip the default for `RESTART_BROKEN_DIFFER` to true instead of false.
|
This has been released and deployed as part of v0.1.2rc1. If it seems stable in production over a few days, we’ll make a final release as-is. If not, we’ll flip the default for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server's process pool (used for actually running the diffs) fails repeatedly, assume it just can't be started and crash the whole server so a process manager can clean things up and totally start over. You can retain the old behavior (where the server keeps trying to start a new process pool if the old one is broken) by setting the
RESTART_BROKEN_DIFFERenvironment variable totrue.Fixes #42.