Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema section of README #72

Closed
4 of 5 tasks
patcon opened this issue Sep 26, 2017 · 5 comments
Closed
4 of 5 tasks

Update schema section of README #72

patcon opened this issue Sep 26, 2017 · 5 comments

Comments

@patcon
Copy link
Member

patcon commented Sep 26, 2017

Slack context: https://archivers.slack.com/archives/C47DJK8H0/p1506368749000003

@Mr0grog said:

The README there is a little confusing and a lot out of date when you get to the schema stuff

Would the following be a good solution for moving that information somewhere less likely to decay?

To Do

Related: swagger-api/swagger-ui#1369 (comment)

@Mr0grog
Copy link
Member

Mr0grog commented Sep 26, 2017

Flesh out swagger.yml API spec to include description…

Also all our existing swagger issues.

Link to db/schema.rb in web-monitoring-db

I am not particularly keen on this idea. That file is very Rails-specific and very much an implementation detail that does not necessarily reflect what you get out of the API.

I guess I should have been more clear in that the “a little confusing” was about the whole Readme, not just the schema section. I feel like I’ve had to fairly consistently re-explain it to a lot of people, so I don’t think it’s doing it’s job of giving an introduction and overview as well as it should.

That said, the above suggestions are good ones for doing away with the schema section and pointing to the resource we are doing a less bad job keeping accurate and up-to-date. That at least solves part of the problem.

@Mr0grog
Copy link
Member

Mr0grog commented Sep 23, 2018

This is addressed in #105, I think. (Or hope?)

@lightandluck
Copy link
Collaborator

Yes, everything is addressed except for the task about enabling deep-linking (working link: https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/deep-linking.md)

Not sure use for this/why?

Mr0grog added a commit to edgi-govdata-archiving/web-monitoring-db that referenced this issue Sep 25, 2018
The upgrade was required for deep linking support. Satisfies the last part of edgi-govdata-archiving/web-monitoring#72.
@Mr0grog
Copy link
Member

Mr0grog commented Sep 25, 2018

Oh, I had totally missed that one (maybe because it says UI instead of DB). I’m guessing that was so parts of the schema section (now gone) could link directly to the correct part of the docs. Still a good idea to do anyway, so I just added edgi-govdata-archiving/web-monitoring-db#396.

Mr0grog added a commit to edgi-govdata-archiving/web-monitoring-db that referenced this issue Sep 26, 2018
The upgrade was required for deep linking support. Satisfies the last part of edgi-govdata-archiving/web-monitoring#72.
@Mr0grog
Copy link
Member

Mr0grog commented Sep 26, 2018

Closing this since all the sub-items are done.

@Mr0grog Mr0grog closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants