Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for socks5 user and pass parameters. #323

Merged
merged 3 commits into from
Apr 18, 2018
Merged

add support for socks5 user and pass parameters. #323

merged 3 commits into from
Apr 18, 2018

Conversation

skie
Copy link
Contributor

@skie skie commented Apr 16, 2018

Hackney supports the connection via a socks5 proxy. To set a socks5 proxy, it uses the following settings:

  • {proxy, {socks5, ProxyHost, ProxyPort}}: to set the host and port of the proxy to connect.
  • {socks5_user, Username}: to set the user used to connect to the proxy
  • {socks5_pass, Password}: to set the password used to connect to the proxy

This info from hackney documentation.

This PR adding support of socks5_user and socks5_pass.

@edgurgel
Copy link
Owner

Hey thanks for the PR. Could you please add a test similar to this one to check for this option?

https://github.com/edgurgel/httpoison/blob/master/test/httpoison_base_test.exs#L121-L133

@skie
Copy link
Contributor Author

skie commented Apr 18, 2018

Testcase added. Additionally i added example how propertly define socks5 proxy using tuple. It was not clear for me that I must use single quotes for hostname.

@edgurgel
Copy link
Owner

Thanks!

@edgurgel edgurgel merged commit e3b1e20 into edgurgel:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants