Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTPoison.Request.to_curl/1 to get an equivalent curl command #459

Merged
merged 2 commits into from
May 17, 2022
Merged

Add HTTPoison.Request.to_curl/1 to get an equivalent curl command #459

merged 2 commits into from
May 17, 2022

Conversation

dariodf
Copy link
Contributor

@dariodf dariodf commented May 1, 2022 •
edited
Loading

Generates an equivalent curl command for a %HTTPoison.Request{}.

Cases not covered by this PR (will throw a "not supported" result):

  • :multipart body
  • :hackney options

Partially solves #348

@Zarathustra2
Copy link
Contributor

Would love to get this in

edgurgel
edgurgel reviewed May 17, 2022
View reviewed changes
Copy link
Owner

@edgurgel edgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition! Thanks and sorry for the super late feedback.
I've added a few comments!

lib/httpoison.ex Outdated Show resolved Hide resolved
lib/httpoison.ex Show resolved Hide resolved
@dariodf dariodf requested a review from edgurgel May 17, 2022 03:24
@edgurgel edgurgel merged commit 2fca7b8 into edgurgel:main May 17, 2022
@edgurgel
Copy link
Owner

Thanks, @dariodf ! 🎉 Will get a release out soon

@dariodf
Copy link
Contributor Author

dariodf commented Aug 4, 2022

Thanks, @dariodf ! tada Will get a release out soon

Hi! Will a release with this change come out soon? Thanks in advance!

@edgurgel
Copy link
Owner

edgurgel commented Aug 4, 2022

@dariodf oh yes! Sorry for that! Will release a new version later today. Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgurgel edgurgel Awaiting requested review from edgurgel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariodf @Zarathustra2 @edgurgel