Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the request!/1 function #473

Merged
merged 3 commits into from
May 3, 2023
Merged

Add the request!/1 function #473

merged 3 commits into from
May 3, 2023

Conversation

GuillaumeMilan
Copy link
Contributor

The request!/1 request was missing from the repository

@edgurgel
Copy link
Owner

Thanks! Would you mind adding some tests? Cheers!

@GuillaumeMilan
Copy link
Contributor Author

Thanks! Would you mind adding some tests? Cheers!

Added some tests.
But as the request function didn't had one I don't really know you want me to test (what is common between request and the other functions in the engine?)

@edgurgel
Copy link
Owner

edgurgel commented May 3, 2023

Tests are good! We just need to mix format it now

@GuillaumeMilan
Copy link
Contributor Author

Sorry I don't have the reflexe to trigger it
Done 👍

@edgurgel edgurgel merged commit b2d4438 into edgurgel:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgurgel edgurgel edgurgel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeMilan @edgurgel