Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
location: :keep
option to thequote
in the__using__/1
macro. These gives better stack traces if and when unexpected errors are raised somewhere in the code. Otherwise the stack tops out atuse HTTPoison.Base
inHTTPoison
or whever the base is being used.The PR also includes:
ssl_verify_fun
as otherwise I can't get things to compile (at least with Elixir 1.5 / Erlang 26 on OS X and Ubuntu)Oh, and it looks like
mix format
has gone and changed a bunch of charlist strings to use the ~c sigil. ¯\(ツ)/¯ . I can revert that if you like."test ssl config tests https scheme" in
HTTPoisonTest
is still failing in Elixir 1.5 but I don't know why. Something to do withhttparrot
and ssl.