-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitespace control #10
Labels
Milestone
Comments
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 21, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 21, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Jcambass
pushed a commit
to Jcambass/solid
that referenced
this issue
Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags. It only implements support for the whitespace object tags `{{-` and `-}}`. Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments. In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`. I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken. Some guidance would be appreciated if possible. Needed by edgurgel#10
Closed by #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://shopify.github.io/liquid/basics/whitespace/
The text was updated successfully, but these errors were encountered: