Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace control #10

Closed
edgurgel opened this issue Apr 16, 2017 · 1 comment
Closed

Whitespace control #10

edgurgel opened this issue Apr 16, 2017 · 1 comment
Milestone

Comments

@edgurgel
Copy link
Owner

https://shopify.github.io/liquid/basics/whitespace/

@edgurgel edgurgel added this to the Solid 1.0 milestone Aug 10, 2019
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 19, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 21, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 21, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
Jcambass pushed a commit to Jcambass/solid that referenced this issue Feb 22, 2021
This patch is the first step towards supporting the Whitespace Control tags.
It only implements support for the whitespace object tags `{{-` and `-}}`.

Support for the tags is more complicated since the `Tag.eval/3` function needs to support the `trim_previous` and `trim_next` arguments.
In some cases there are multiple of them and we need to forward them to further calls of `Solid.render/3`.

I'm very new to NimbleParsec and generally parsers so I'm posting this to get verification on the current path I have taken.
Some guidance would be appreciated if possible.

Needed by edgurgel#10
@edgurgel
Copy link
Owner Author

edgurgel commented Sep 6, 2021

Closed by #84

@edgurgel edgurgel closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant