Add missing filters

[edgurgel]

Missing filters:

• at_most
• at_least
• date
• modulo Implement modulo #54
• newline_to_br Implement strip_newlines and newline_to_br filter #56
• strip_html Implement strip_html filter #57
• strip_newlines Implement strip_newlines and newline_to_br filter #56
• where Implement where filter #55
• escape
• escape_once
• concat
• url_decode
• url_encode

[barkerja]

@edgurgel How do you feel about support for custom filters? I was thinking a configuration that allows for defining a module. Solid.Filter.filter_exists?/2 would check for this configuration, defaulting to any custom defined filters before checking the defaults in Solid.Filter.

This would allow for filters that may fall outside the scope of what the liquid spec defines, and also control dependencies (ex: an integrator may want to use Timex to format dates, but Solid should not have it as a hard dep).

[LostKobrakai]

date could use https://github.com/plataformatec/nimble_strftime. It doesn't depend on any additional libraries and only does formatting.

[edgurgel]

@LostKobrakai that's pretty handy Thanks for the tip! 👍

[sb8244]

Wasn't sure if this is the right place to track it, but I'm wondering if .size should be supported in if tag?

I was able to recreate this functionality with assign, though:

            {% assign article_size = child.articles | size %}
            {% if article_size < child.article_count %}

[edgurgel]

@sb8244 it should be supported yes! . Thanks for bringing this up! Issue created: #47

[wmnnd]

@edgurgel Would you be open to a PR that implements the date filter with Elixir 1.11’s new Calendar.strftime/3 function?

[edgurgel]

@wmnnd 100%! Then we just bump the elixir requirement accordingly 😎

[wmnnd]

@edgurgel Awesome! I’ll create a PR tomorrow.

[LostKobrakai]

I've just added PRs for the rest besides strip_html. strip_newlines and newlines_to_br are naive implementations right now however, as they do not retain the iolist of the supplied template, but normalize to a binary.

Edit: There's a PR for strip_html now as well. It uses the same naive regex method the ruby library uses.

[LostKobrakai]

It seems like the current CI build is broken because the where filter was only added on 4.0.2, while CI uses 4.0.0

[edgurgel]

Thanks for the heads up! Speaking of CI I should move this to GHA one day 🤔

[edgurgel]

I've just updated the ticket with the remaining filters (they were added after the issue got created)

escape
escape_once
concat
prepend
url_decode
url_encode

[Jcambass]

I Will prepare a patch for concat and prepend later today.

EDIT: I think prepend is already supported?

[edgurgel]

@Jcambass yes you are right! My bad! 🤦

[LostKobrakai]

I'm already on the two missing filters. Just need to look into escape_once. Seems like Plug.HTML does currently only do raw escaping.

[edgurgel]

Thanks, everyone! 🎉