Tests, Add New assert_render helper #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing whitespace support I came to the conclusion that it makes sense to auto generate different whitespace trimming variants of a given template to gain a good test coverage of edge cases while keeping test maintainable.
One problem I encountered, was that since the templates where generated I didn't know the actual input that was used when comparing the render results of liquid and solid.
My solution was adding a new
assert_render
macro that renders the template in liquid and solid and then compares them (as we do already withcases_test
), but then includes the passed template in the assertion output if there is an missmatch.I'm trying to keep the main patch for the whitespace support as small and reviewable as possible.
Since this particular change can stand alone and IMHO makes also sense outside of the context of whitespace support I've opened this PR.
Sample output: