Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Bearer Authorization #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kilianmh
Copy link

Added bearer-authorization and proxy-bearer-authorization.
When (and bearer-authorization basic-authorization) or
(and proxy-bearer-authorization proxy-basic-authorization)
an error is signaled.

Also added tests for error signalling and whether the authorization value appears appropriately in the header.

Added bearer-authorization and proxy-bearer-authorization.
When (and bearer-authorization basic-authorization) or
     (and proxy-bearer-authorization proxy-basic-authorization)
an error is signaled.

Also added tests for error signalling and whether the authorization
value appears appropriately in the header.
@stassats
Copy link
Member

Is it substantially better than just using :additional-headers?

@kilianmh
Copy link
Author

Bearer authorization is widespread nowadays, e.g. for oauth2 and api calls.

Is it substantially better than just using :additional-headers?

Adding new parameters makes it more convenient and less error prone (no typo in "Bearer ").

There is also a sanity check that basic-authorization is not supplied at the same time with
bearer-authorization. We could also add a check that gives an error when another
authorization header is present in :additional-headers, but that might impact performance more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants