feat(conversation): #WB-3428, folders menu navigation #566
Conversation
jcbe-ode
changed the title
|
Draft PR ouverte, mais j'attaque le rendu du menu mobile ;-) |
| isChild?: boolean; | ||
| }) { | ||
| return ( | ||
| <span className="user-folder w-100 d-flex justify-content-between align-content-center align-items-center"> |
There was a problem hiding this comment.
Petit détail, mais pourquoi un span et pas un div ?
There was a problem hiding this comment.
A priori, ça doit être un résidu des devs itératifs effectués en local, avant que l'élément passe en d-flex
|
|
||
| function renderFolderItem(item: FolderItem) { | ||
| return ( | ||
| <span className="w-100 d-flex justify-content-between align-content-center align-items-center"> |
There was a problem hiding this comment.
Même réponse... On doit pouvoir changer en div si ça chagrine certains puristes.
| import { actionsQueryOptions, folderQueryOptions } from '~/services/queries'; | ||
| import './index.css'; |
There was a problem hiding this comment.
Clément m'a dit de faire comme ça, pour appliquer du CSS très spécifique à un composant non-réutilisable ailleurs.
(et idéalement de nommer le fichier css avec le même nom que le composant auquel il s'applique)
There was a problem hiding this comment.
si j'ai bien compris, le bundler le transforme le CSS en JS, exécuté lorsque le composant est utilisé.
* feat(conversation): #WB-3428, left menu navigation * wip * wip * Desktop Menu with counters * Wip: Mobile Menu with counters * wip * feat: Mobile Menu with counters and navigation * wip * feat(conversation): actions on folders * fix: feedback from PR
Description
Navigation through a menu of system (inbox, outbox, draft and trash) and user's folders.
Displays unread messages in badges, excepting the draft folder which displays its total number of drafts.
Renders differently in desktop or mobile responsive modes.
Fixes
WB-3428
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Added a service and a dedicated test.
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃