fix: WB-3666, optimize voluminous shares request #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbe-ode
reviewed
Jan 14, 2025
| .collect(Collectors.toList())) | ||
| .onFailure(th -> { | ||
| log.error("Failed fetching visibles", th); | ||
| promise.fail("Failed fetching visibles : " + th.getMessage()); |
There was a problem hiding this comment.
Ce cas est traité volontairement ?
Car UserUtils.findVisibles n'échoue jamais : il renvoie un tableau vide et génère un log en cas d'erreur.
Du coup cette ligne de code (ce onFailure en fait) ne sera jamais atteinte.
There was a problem hiding this comment.
Bien vu, je retire le onFailure
juniorode
reviewed
Jan 16, 2025
| break; | ||
|
|
||
| // Parallelizing the process of fetching the visibles | ||
| final int partitionSize = 50; |
There was a problem hiding this comment.
Il faudrait plutôt réussir à récupérer ça de la conf. Pour que ce soit transverse on pourrait s'appuyer sur la conf que passe déjà Starter
juniorode
reviewed
Jan 16, 2025
| @@ -218,7 +219,7 @@ public static void findVisibles(EventBus eb, String userId, String customReturn, | |||
| m.put("additionnalParams", additionnalParams); | |||
| } | |||
| m.put("userId", userId); | |||
| eb.request(COMMUNICATION_USERS, m, new Handler<AsyncResult<Message<JsonArray>>>() { | |||
| eb.request(COMMUNICATION_USERS, m, new DeliveryOptions().setSendTimeout(60000), new Handler<AsyncResult<Message<JsonArray>>>() { | |||
There was a problem hiding this comment.
Cette valeur aussi si on peut la reprendre de la conf ce serait super
mariusode
added a commit
that referenced
this pull request
Jan 16, 2025
* fix: WB-3666, optimize voluminous shares * fix: WB-3666, fix after review * fix: WB-3666, shares optims parameterizable
mariusode
added a commit
that referenced
this pull request
Jan 16, 2025
* fix: WB-3666, optimize voluminous shares * fix: WB-3666, fix after review * fix: WB-3666, shares optims parameterizable
mariusode
added a commit
that referenced
this pull request
Jan 16, 2025
* fix: WB-3666, optimize voluminous shares * fix: WB-3666, fix after review * fix: WB-3666, shares optims parameterizable
jcbe-ode
pushed a commit
that referenced
this pull request
Jan 17, 2025
* fix: WB-3666, optimize voluminous shares * fix: WB-3666, fix after review * fix: WB-3666, shares optims parameterizable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lorsque les favoris de partage contiennent un nombre important d'utilisateurs, la requête de recherche des utilisateurs visibles peut atteindre un timeout.
Actions réalisées :
Avec ces changements on parvient à répondre dans cas reproductible en recette-release : le partage à un favoris contenant plus de 4000 utilisateurs.
Fixes
https://edifice-community.atlassian.net/browse/WB-3666
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Tests manuels directement sur recette-release (environnement pour lequel le bug était reproductible)
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃