Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversation): #WB-3881 conversation recipient list #601

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

damienromito
Copy link

@damienromito damienromito commented Feb 20, 2025

Description

Add list of recipients in message header
Ticket
Specs

Fixes

(Enter here Jira or Redmine ticket(s) links)

Type of change

Please check options that are relevant.

  • Chore (PATCH)
  • Doc (PATCH)
  • Bug fix (PATCH)
  • New feature (MINOR)

Which packages changed?

Please check the name of the package you changed

  • admin
  • app-registry
  • archive
  • auth
  • cas
  • common
  • communication
  • conversation
  • directory
  • feeder
  • infra
  • portal
  • session
  • test
  • tests
  • timeline
  • workspace

Tests

Message header ...

  • should display recipient list for To, Cc and Cci
  • should display recipient list for To but not Cc and Cci

Recipient list...

  • should render a label
  • should display "Me" instead of the first name when the user is the logged-in user
  • should open the userbook in a new tab when clicking on a user
  • should open the userbook in a new tab when clicking on a group

Reminder

  • Security flaws

  • Performance impacts (think bulk !)

  • Unit tests were replayed

  • Unit tests were added and/or changed

  • I have updated the reminder for the version including my modifications

  • All done ! 😃

@damienromito damienromito changed the title Feat wb 3881 conversation to list Feat wb 3881 conversation recipient list Feb 21, 2025
@damienromito damienromito self-assigned this Feb 24, 2025
@damienromito damienromito marked this pull request as ready for review February 24, 2025 13:23
@damienromito damienromito changed the title Feat wb 3881 conversation recipient list Feat(conversation): #WB-3881 conversation recipient list Feb 24, 2025
@Romu-C Romu-C changed the title Feat(conversation): #WB-3881 conversation recipient list feat(conversation): #WB-3881 conversation recipient list Feb 24, 2025
Copy link
Contributor

@jcbe-ode jcbe-ode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un micro-détail... autrement bravo, le code est propre.

@damienromito damienromito merged commit ebf5b67 into develop-b2school Feb 26, 2025
@damienromito damienromito deleted the feat-WB-3881-conversation-to-list branch February 26, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants