Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat wb 3801 adapt legacy visibles #613

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

mariusode
Copy link
Contributor

@mariusode mariusode commented Mar 4, 2025

Description

Nouvelle API de recherche des utilisateurs visibles.
On utilise par défaut la version allégée.

Si besoin de désengager cette nouvelle API car les perfs sont problématiques, l'ancienne API a été adaptée pour retourner les informations au même format que la nouvelle API.

Remarque

À cause d'un rebase de la branche develop-b2school sur dev, un nouvelle branche pour feat-WB-3801 a été créée à partir de la version à jour de develop-b2school.
La PR associée à la branche initiale : #603

Fixes

https://edifice-community.atlassian.net/browse/WB-3801

Type of change

Please check options that are relevant.

  • Chore (PATCH)
  • Doc (PATCH)
  • Bug fix (PATCH)
  • New feature (MINOR)

Which packages changed?

Please check the name of the package you changed

  • admin
  • app-registry
  • archive
  • auth
  • cas
  • common
  • communication
  • conversation
  • directory
  • feeder
  • infra
  • portal
  • session
  • test
  • tests
  • timeline
  • workspace

Tests

Tests dev manuels et tests k6 de présence des champs legacy vs light

Reminder

  • Security flaws

  • Performance impacts (think bulk !)

  • Unit tests were replayed

  • Unit tests were added and/or changed

  • I have updated the reminder for the version including my modifications

  • All done ! 😃

@mariusode mariusode merged commit b60e59f into develop-b2school Mar 5, 2025
@mariusode mariusode deleted the feat-WB-3801-adapt-legacy-visibles branch March 5, 2025 10:00
Copy link
Contributor

@jcbe-ode jcbe-ode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste une question : les données retournées par l'API de recherche des visibles "augmentée via feature-flag" sont 100% rétro-compatibles, si le feature-flag est désactivé ?
Car l'API est certainement utilisée ailleurs que dans Conversation.

@mariusode
Copy link
Contributor Author

Bonne question.
Conversation appelle un nouveau point d'entrée, qui appelle une nouvelle méthode du service.
Le changement de feature flag n'aura d'effet que sur ce que récupère Conversation.

Romu-C pushed a commit that referenced this pull request Mar 6, 2025
* chore: prepare develop-b2school version

* feat(communication): MOZO-206, new search visible API for messaging

* feat: MOZO-206 light version of search visibles

* feat: WB-3801, adapt legacy visible result to new api format

* feat: WB-3801, fix after merge

---------

Co-authored-by: Jean-Christophe <jean-christophe.benoit@opendigitaleducation.com>
Co-authored-by: Zakaria BANI <zakaria.bani@edifice.io>
Co-authored-by: Junior BERNARD <junior.bernard@opendigitaleducation.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants