Feat(conversation)#WB-3834 draft list message preview #620

damienromito · 2025-03-10T13:52:51Z

Description

-Afficher la liste des destinataires plutôt que l’expéditeur (+avatar correspondant)
-Afficher le label “brouillon” devant le destinataire de chaque message
-Possibilité d’avoir aucun destinataire renseigné

Fixes

(Enter here Jira or Redmine ticket(s) links)

Type of change

Please check options that are relevant.

Chore (PATCH)
Doc (PATCH)
Bug fix (PATCH)
New feature (MINOR)

Which packages changed?

Please check the name of the package you changed

Tests

-should display a "draft" label when in draft
-should display all recipients without "to" label when in draft
-should not display any recipients if there are none when in draft

Reminder

Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃

…r in message list

…t list

… list + improve accessibility

jcbe-ode

2 petits ajustements à appliquer

jcbe-ode · 2025-03-11T07:20:22Z

...ation/frontend/src/features/message-list/message-preview/components/RecipientListPreview.tsx

@@ -4,9 +4,13 @@ import { MessageMetadata } from '~/models';

 export interface RecipientListPreviewProps {
  message: MessageMetadata;
+  hasPrefix?: boolean;


Suggested change

hasPrefix?: boolean;

head?: string;

jcbe-ode · 2025-03-11T07:21:59Z

...ation/frontend/src/features/message-list/message-preview/components/RecipientListPreview.tsx

@@ -17,7 +21,7 @@ export function RecipientListPreview({ message }: RecipientListPreviewProps) {
  };
  return (
    <MessageRecipientList
-      head={t('at')}
+      head={hasPrefix ? t('at') : null}


Suggested change

head={hasPrefix ? t('at') : null}

head={head}

ou
{...otherProps}

jcbe-ode · 2025-03-11T07:27:07Z

...ation/frontend/src/features/message-list/message-preview/components/RecipientListPreview.tsx

-export function RecipientListPreview({ message }: RecipientListPreviewProps) {
+export function RecipientListPreview({
+  message,
+  hasPrefix,


Suggested change

hasPrefix,

head,

ou }, ...otherProps

jcbe-ode · 2025-03-11T07:32:01Z

conversation/frontend/src/features/message-list/message-preview/index.tsx

-              senderDisplayName
+            {folderId === 'draft' && <RecipientListPreview message={message} />}
+            {folderId === 'outbox' && (
+              <RecipientListPreview message={message} hasPrefix />


Suggested change

<RecipientListPreview message={message} hasPrefix />

<RecipientListPreview message={message} head={t('at')} />

jcbe-ode · 2025-03-11T07:39:03Z

conversation/frontend/src/features/message-list/message-preview/index.tsx

@@ -24,21 +24,27 @@ export function MessagePreview({ message }: MessagePreviewProps) {
        <IconUndo className="gray-800" title="message-response" />
      )}

-      {'outbox' === folderId ? (
+      {folderId && ['outbox', 'draft'].includes(folderId) ? (


Dans l'ancienne messagerie, les noms des dossiers étaient en majuscule.
La comparaison ici ne tient pas compte de la casse, on risque donc d'avoir des effets de bord en ouvrant une URL à l'ancien format.
=> Il faut que le paramètre folderId soit "normalisé", et c'est justement ce que fait le hook useSelectedFolder, à utiliser à la place de useParams

@Romu-C ce hook sert donc à ça !

donc on remplace useSelectedFolder partout ? histoire d'être consistant

je vois qu'il y a aussi une constante SYSTEM_FOLDER_ID . Ça serait mieux de l'utiliser non ?

export const SYSTEM_FOLDER_ID = { INBOX: 'inbox', OUTBOX: 'outbox', DRAFT: 'draft', TRASH: 'trash', }

=> folderId === SYSTEM_FOLDER_ID.DRAFT ?

Il vaudrait mieux, oui (x2). A discuter plus en détails si le moindre doute persiste.

evanthonyly · 2025-03-11T16:06:58Z

conversation/frontend/src/features/message-list/message-preview/components/RecipientAvatar.tsx

@@ -12,7 +12,17 @@ export function RecipientAvatar({ recipients }: RecipientAvatarProps) {
  const { t } = useTranslation('conversation');
  const { recipientCount, url } = useRecipientAvatar(recipients);

-  if (recipientCount > 1) {
+  if (recipientCount === 0) {


Tu peux refacto pour éviter la répétition et virer le else inutile :

if (recipientCount === 1 && url) { return <Avatar alt={t('recipient.avatar')} size="sm" src={url} variant="circle" />; } const avatars = { 0: { bg: 'bg-yellow-200', label: t('recipient.avatar.empty'), icon: <IconQuestionMark className="w-16" /> }, 1: { bg: 'bg-orange-200', label: t('recipient.avatar.group'), icon: <IconGroupAvatar className="w-16" /> }, }; const avatar = avatars[Math.min(recipientCount, 1)]; return avatar ? ( <div className={`${avatar.bg} avatar avatar-sm rounded-circle`} aria-label={avatar.label} role="img" > {avatar.icon} </div> ) : null;

…ctedFolder hook

* feat(conversation): #WB-3834 draft - show recipient rather than sender in message list * feat(conversation): #WB-3834 draft - show draft label before recipient list * feat(conversation): #WB-3834 draft - hide "at" label before recipient list + improve accessibility * feat(conversation): #WB-3834 draft - possible to have any recipients * feat(conversation): #WB-3834 draft - add empty recipient icon * fix(conversation): #WB-3834 draft - review * fix(conversation): #WB-3834 draft - review - add system folder id * fix(conversation): #WB-3834 draft - review * fix(conversation): #WB-3834 draft - add SystemFolder type for useSelectedFolder hook

damienromito self-assigned this Mar 10, 2025

damienromito added 4 commits March 10, 2025 15:12

feat(conversation): #WB-3834 draft - show recipient rather than sende…

06d3022

…r in message list

feat(conversation): #WB-3834 draft - show draft label before recipien…

c5726a2

…t list

feat(conversation): #WB-3834 draft - hide "at" label before recipient…

2cfb25b

… list + improve accessibility

feat(conversation): #WB-3834 draft - possible to have any recipients

28b5f9f

damienromito marked this pull request as ready for review March 10, 2025 16:28

damienromito changed the base branch from master to develop-b2school March 10, 2025 16:28

damienromito requested review from jcbe-ode, juniorode, evanthonyly and Romu-C and removed request for juniorode March 10, 2025 16:29

damienromito changed the title ~~Feat(conversation)#WB-3834 draft list~~ Feat(conversation)#WB-3834 draft list message preview Mar 10, 2025

jcbe-ode requested changes Mar 11, 2025

View reviewed changes

damienromito added 2 commits March 11, 2025 14:38

feat(conversation): #WB-3834 draft - add empty recipient icon

526c5c9

fix(conversation): #WB-3834 draft - review

a723fd9

damienromito requested a review from jcbe-ode March 11, 2025 14:19

fix(conversation): #WB-3834 draft - review - add system folder id

bc9da43

Romu-C approved these changes Mar 11, 2025

View reviewed changes

evanthonyly reviewed Mar 11, 2025

View reviewed changes

damienromito added 2 commits March 12, 2025 11:20

fix(conversation): #WB-3834 draft - review

9ec254c

fix(conversation): #WB-3834 draft - add SystemFolder type for useSele…

01e2514

…ctedFolder hook

damienromito merged commit d443f7d into develop-b2school Mar 12, 2025

damienromito deleted the feat/#WB-3834-draft-list branch March 12, 2025 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(conversation)#WB-3834 draft list message preview #620

Feat(conversation)#WB-3834 draft list message preview #620

damienromito commented Mar 10, 2025 •

edited

Loading

jcbe-ode left a comment

jcbe-ode Mar 11, 2025

jcbe-ode Mar 11, 2025

jcbe-ode Mar 11, 2025

jcbe-ode Mar 11, 2025

jcbe-ode Mar 11, 2025

damienromito Mar 11, 2025

damienromito Mar 11, 2025 •

edited

Loading

damienromito Mar 11, 2025 •

edited

Loading

jcbe-ode Mar 11, 2025

evanthonyly Mar 11, 2025

	<RecipientListPreview message={message} hasPrefix />
	<RecipientListPreview message={message} head={t('at')} />

Feat(conversation)#WB-3834 draft list message preview #620

Feat(conversation)#WB-3834 draft list message preview #620

Conversation

damienromito commented Mar 10, 2025 • edited Loading

Description

Fixes

Type of change

Which packages changed?

Tests

Reminder

jcbe-ode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damienromito Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

damienromito Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damienromito commented Mar 10, 2025 •

edited

Loading

damienromito Mar 11, 2025 •

edited

Loading

damienromito Mar 11, 2025 •

edited

Loading