Add all_deletion_coordinates to be returned by find_indels_substitutions_legacy function
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colelyman
added a commit
that referenced
this pull request
Sep 13, 2024
…utions_legacy` function (#106) (pinellolab#486) * Add all_deletion_coordinates to find_indels_substitutions_legacy * Update test cases to include find_indels_substitutions_legacy and all_deletion_coordinates
mbowcut2
pushed a commit
that referenced
this pull request
Oct 14, 2024
…utions_legacy` function (#106) (pinellolab#486) * Add all_deletion_coordinates to find_indels_substitutions_legacy * Update test cases to include find_indels_substitutions_legacy and all_deletion_coordinates
mbowcut2
pushed a commit
that referenced
this pull request
Nov 8, 2024
…utions_legacy` function (#106) (pinellolab#486) * Add all_deletion_coordinates to find_indels_substitutions_legacy * Update test cases to include find_indels_substitutions_legacy and all_deletion_coordinates
mbowcut2
pushed a commit
that referenced
this pull request
Nov 8, 2024
…utions_legacy` function (#106) (pinellolab#486) * Add all_deletion_coordinates to find_indels_substitutions_legacy * Update test cases to include find_indels_substitutions_legacy and all_deletion_coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
all_deletion_coordinateslist to be returned by thefind_indels_substitutions_legacyfunction. Without this, when one would use the--use_legacy_insertion_quantificationparameter aKeyErrorwould be thrown.This also updates the unit tests to catch this error.