Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib compatibility #93

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Matplotlib compatibility #93

merged 1 commit into from
Aug 1, 2024

Conversation

Snicker7
Copy link
Collaborator

Add a try catch block to prevent renamed keys from causing plotting errors in matplotlib v3.9.0.

@Snicker7 Snicker7 requested a review from Colelyman July 30, 2024 20:05
@Snicker7 Snicker7 self-assigned this Jul 30, 2024
@Snicker7
Copy link
Collaborator Author

Prevents issues with matplotlib. I tested versions 3.8.9 and 3.9.0 (before and after breaking change). Since the except only catches attribute errors, other errors should still show up as previously intended.

Copy link
Collaborator

@Colelyman Colelyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @Snicker7!

@Colelyman
Copy link
Collaborator

Let's merge it in after the d3 PR gets merged into pinellolab pinellolab#459

@kclem kclem merged commit 653204b into master Aug 1, 2024
6 checks passed
@kclem kclem deleted the matplotlib_compat branch August 1, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants