Reduce memory usage in plot_alleles_table
#96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colelyman
force-pushed
the
cole/reduce-plot-mem
branch
from
769e5f3 to
1d9c799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
prep_alleles_tablefunction out of theplot_alleles_tablefunction to minimize the amount of data copied over to other parallel processes. This makes it possible to analyze datasets with a large number of alleles with less memory.@kclem there are some other places that we could make this change, namely in https://github.com/edilytics/CRISPResso2/blob/master/CRISPResso2/CRISPRessoCompareCORE.py#L409 but we don't use multiprocessing here, so it wouldn't change how much memory is used. Do you think we should refactor this as well?