Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta-mingw patch for SDKTAROPTS #22

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

alext-mkrs
Copy link
Collaborator

@alext-mkrs alext-mkrs commented Jun 6, 2018

Okay, so looks like that meta-mingw patching problem we discussed in htot#6 still exists, at least in master. Here's a fix.

Master is a current branch for development and it should be stable enough to run on Edison, right? Except for ACPI being enabled by default maybe.

Signed-off-by: Alex Tereschenko <alext.mkrs@gmail.com>
@alext-mkrs alext-mkrs requested a review from htot June 6, 2018 20:11
@htot
Copy link
Member

htot commented Jun 6, 2018

Yes, rocko branch has 10 commits more, including something to fix this. I was workiing on other stuff (fixing hsu, i2c working on non-acpi : ugly, trying preempt_rt). I'll try to find time to review this tomorrow. Also update rocko and send you a review request.
One thing not yet fixed: initramsfs might need a DEPENDS on kernel-modules. For now I just do bitbake -k a 2nd time.
Also I found we should move to 32 bit. There are things not working with hsu on 64 bit that I can't seem to fix. And interrupt latency is much slower.

@alext-mkrs
Copy link
Collaborator Author

alext-mkrs commented Jun 7, 2018

By "rocko branch" you mean "rocko64-acpi"? I though that one is abandoned these days. Okay, so let me wait for your merge before I proceed with that regulatory DB stuff, so that we work off of the same set of recipes.

As for 32 vs 64 bits - to be honest I thought this was unnecessary for Edison's case - having just 1 GB of RAM we are only wasting it on 64. Not sure if anything would run faster when compiled 32 vs 64, but my wild guess would be "none to marginal" difference. But I'd be curious to know if anyone actually tried and benchmarked it.

@htot
Copy link
Member

htot commented Jun 7, 2018

Yes, that's it. It's my development branch.

In fact I know someone who has been benching:
https://github.com/htot/crc32c
https://github.com/htot/base64

On 64b certain instructions should be a lot faster. But also I discovered that on silvermont (Baytrail NUC, Edison) there is a severe penalty when instructions become too long. Then however, when they are used in a long (> 100 iterations) the penalty does not apply. Haven't applied applied the latter on crc32 yet, but should give a speedup of 3x on 64b on long buffers.

@htot htot merged commit 6a7d048 into edison-fw:master Jun 7, 2018
@htot
Copy link
Member

htot commented Jun 7, 2018

Your patch and mine were same, but you had correct ref to original author so I took yours, thanks. Added one more to clean up the obsolete patch from utils. Now will rebase rocko64 and send PR for you to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants