Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TypeScript #73

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Migrate to TypeScript #73

merged 3 commits into from
Jul 19, 2024

Conversation

idebenone
Copy link
Member

@idebenone idebenone commented Jul 16, 2024

Problem

Importing this package in TS project leads a TS error: codex-team/editor.js#2143

Cause

This tool was built in JavaScript to be a simplest example of Editor.js Tools API usage.

Solution

To resolve the TypeScript error mentioned in issue #2143, the entire codebase of this tool has been migrated from JavaScript to TypeScript. This migration involves several key steps:

  • Renaming JavaScript files ".js" to TypeScript ".ts".
  • Update project configuration to support TypeScript.
  • Refactor the code necessary to align with TypeScript's stricter type rules.

Resolves #69

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/types/codexteam-icons.d.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@idebenone idebenone requested a review from neSpecc July 18, 2024 02:54
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attach an issue, please

@idebenone idebenone changed the title Migrating to TypeScript Migrate to TypeScript Jul 19, 2024
@neSpecc neSpecc merged commit 46fd5a9 into editor-js:master Jul 19, 2024
idebenone added a commit to idebenone/code that referenced this pull request Sep 4, 2024
Includes fixes for issues from PR editor-js#73 where deployment failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to TypeScript
2 participants