RootInlineNode #12
Merged
RootInlineNode #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success140 tests passing in 10 suites. Report generated by 🧪jest coverage report action from e194c67 |
gohabereg
changed the base branch from
main
to
feature/formatting-node-unformat
…re/root-inline-node
…e class. Add normalization. Add more tests
neSpecc
reviewed
Aug 27, 2023
src/entities/inline-fragments/specs/InlineTree.integration.spec.ts
Outdated
Show resolved
Hide resolved
| const index = 100; | ||
|
|
||
| expect(() => tree.removeText(index)) | ||
| .toThrowError(); |
There was a problem hiding this comment.
could we also check the error text or type here?
There was a problem hiding this comment.
It's not a good idea to check for error text as we might change it later. We can use custom error classes, but that's a whole big task
There was a problem hiding this comment.
If we change the error text, we can also change it in tests. For now any error thrown during execution of removeText() will lead false-positive test assertion
src/entities/inline-fragments/specs/InlineTree.integration.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
ilyamore88
reviewed
Aug 27, 2023
ilyamore88
reviewed
Aug 27, 2023
Co-authored-by: Ilya Maroz <37909603+ilyamore88@users.noreply.github.com>
ilyamore88
approved these changes
Aug 27, 2023
neSpecc
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds: