chore(eslint): merge with master, and refactor code with eslint confi…

…guration
editor-js · Aug 2, 2024 · b4b9290 · b4b9290
2 parents 66e734b + 5d1c57c
commit b4b9290
Show file tree

Hide file tree

Showing 13 changed files with 744 additions and 772 deletions.
diff --git a/.eslintrc b/.eslintrc
diff --git a/dev/server.js b/dev/server.js
@@ -86,12 +86,12 @@ class ServerExample {
 
     this.getForm(request)
       .then(({files}) => {
-        let image = files[this.fieldName] || {};
+        let image = files[this.fieldName][0] || {};
 
         responseJson.success = 1;
         responseJson.file = {
-          url: image.path,
-          name: image.name,
+          url: 'file://' + image.filepath,
+          name: image.newFilename,
           size: image.size
         };
       })
@@ -147,10 +147,12 @@ class ServerExample {
    */
   getForm(request) {
     return new Promise((resolve, reject) => {
-      const form = new formidable.IncomingForm();
+      const form = new formidable.IncomingForm({
+        uploadDir: this.uploadDir,
+        keepExtensions: true
+      });
 
-      form.uploadDir = this.uploadDir;
-      form.keepExtensions = true;
+      console.error('the form info:', form);
 
       form.parse(request, (err, fields, files) => {
         if (err) {

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,48 @@
+import Codex from "eslint-config-codex";
+import { plugin as TsPlugin, parser as TsParser } from 'typescript-eslint';
+
+export default [
+  ...Codex,
+  {
+    files: ['src/**/*.ts'],
+    languageOptions: {
+      parser: TsParser,
+      parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: './',
+        sourceType: 'module',
+      },
+    },
+    rules: {
+        'n/no-missing-import': ['off'],
+        'n/no-unsupported-features/node-builtins': ['off'],
+        'jsdoc/require-returns-description': ['off'],
+        "@typescript-eslint/naming-convention": [
+          "error",
+          {
+            "selector": "variable",
+            "format": ["camelCase"],
+            "leadingUnderscore": "allow"
+          },
+        ],
+        "@typescript-eslint/ban-types": ["error",
+            {
+                "types": {
+                    "String": true,
+                    "Boolean": true,
+                    "Number": true,
+                    "Symbol": true,
+                    "{}": false,
+                    "Object": true,
+                    "object": false,
+                    "Function": false,
+                },
+                "extendDefaults": true
+            }
+        ]
+    }
+  },
+  {
+    ignores: ['dev/**', 'eslint.config.mjs', 'vite.config.js', 'postcss.config.js']
+  }
+];
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@editorjs/image",
-  "version": "2.9.1",
+  "version": "2.9.3",
   "keywords": [
     "codex editor",
     "image",
@@ -26,9 +26,9 @@
   "scripts": {
     "dev": "vite",
     "build": "vite build",
-    "lint": "eslint src/ --ext .ts",
-    "lint:errors": "eslint src/ --quiet",
-    "lint:fix": "eslint src/ --fix"
+    "lint": "eslint",
+    "lint:errors": "eslint --quiet",
+    "lint:fix": "eslint --fix"
   },
   "author": {
     "name": "CodeX",
@@ -37,16 +37,17 @@
   "devDependencies": {
     "@codexteam/ajax": "^4.2.0",
     "@editorjs/editorjs": "2.30.0-rc.12",
-    "@typescript-eslint/eslint-plugin": "^7.13.1",
-    "@typescript-eslint/parser": "^7.13.1",
-    "eslint": "^7.22.0",
+    "@typescript-eslint/eslint-plugin": "^7.16.1",
+    "@typescript-eslint/parser": "^7.16.1",
+    "eslint": "^9.7.0",
     "eslint-config-codex": "^2.0.1",
     "eslint-loader": "^4.0.2",
     "formidable": "^3.5.1",
     "postcss-nested": "^6.0.1",
     "postcss-nested-ancestors": "^3.0.0",
     "request": "^2.88.0",
     "typescript": "^5.4.5",
+    "typescript-eslint": "^7.17.0",
     "vite": "^5.3.1",
     "vite-plugin-css-injected-by-js": "^3.5.1",
     "vite-plugin-dts": "^3.9.1"