Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix (helpers): fix circular reexport #27

Merged
merged 3 commits into from
Nov 6, 2024
Merged

bugfix (helpers): fix circular reexport #27

merged 3 commits into from
Nov 6, 2024

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Nov 6, 2024

Problem

Circular dependencie in the helpers package empty directory
This causes this build errors

Export "isEmpty" of module "node_modules/@editorjs/helpers/dist/empty/isEmpty.js" was reexported through module "node_modules/@editorjs/helpers/dist/empty/index.js" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Either change the import in "node_modules/@editorjs/helpers/dist/index.js" to point directly to the exporting module or reconfigure "output.manualChunks" to ensure these modules end up in the same chunk.

Solution

mentioned imported file directly to solve circular dependencie

@e11sy e11sy changed the title bug (helpers): fix circular reexport bugfix (helpers): fix circular reexport Nov 6, 2024
bump caret and dom version since they have actual version of the helpers package in dependencies. Caret and Dom should mention version of the helpers with bugfix
@e11sy e11sy merged commit c566cf5 into main Nov 6, 2024
3 checks passed
@e11sy e11sy deleted the fix-reexport branch November 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants