feat(migration): migrate project to typescript #47
+2,341
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedatigui
commented
Nov 19, 2024
ahmedatigui
commented
- migrate the project to typescript
- update the codex-icons package to provide types
neSpecc
reviewed
Nov 19, 2024
src/index.ts
Outdated
Comment on lines
31
to
35
| * @typedef {object} WarningData | ||
| * @description Warning Tool`s input and output data | ||
| * @property {string} title - warning`s title | ||
| * @property {string} message - warning`s message | ||
| * | ||
| */ |
There was a problem hiding this comment.
please move comments from JSDoc to typescript properties
src/index.ts
Outdated
Comment on lines
69
to
70
| titlePlaceholder: string; | ||
| messagePlaceholder: string; |
There was a problem hiding this comment.
please, specify access modifier and add jsdocs for each class property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.