Dont popup console for GotoDef error because its disruptive

[LordZane]

Version of VSCode: 1.9.1
Version of the extension: 0.3.8
OS: Arch Linux (4.9.11-1-ARCH)

Description: Pressing Ctrl on something where you cant go to defenition pops up the console. It would be nice to not pop up the console for this error, because it occurs frequently when trying to GotoDef on something but your mouse is slightly off the text, and popping up the console is disruptive

Output of the "Rust logging" channel:

[Error - 2:09:33 PM] Request textDocument/definition failed.
  Message: GotoDef failed to complete successfully
  Code: -32601

[KalitaAlexey]

Hello @LordZane,
Thank you for your idea.
It is easy change.

[brendanzab]

Is this in the published plugin? Because I am still seeing it on macOS when holding down the command key.

VS Code: 1.11.2
Plugin: 0.3.11
OS: macOS 10.12.4

[KalitaAlexey]

Yes it is.
Try to setrust.rls.revealOutputChannelOn.

{
"rust": {
  "rls": {
    "revealOutputChannelOn": "never"
  }
}
}

[brendanzab]

Oooh, right. Wondering if that should be the default?

[KalitaAlexey]

No, it shouldn't.
The default is "error".
If popping up bothers up, you should turn it off.
But it should be shown when an error occurs, don't you think so?

[brendanzab]

Maybe this is a problem with the log level of the 'GotoDef' log in the RLS? From a UI point of view I just want the blue underline not to show - like it does in Racer mode.

[brendanzab]

Possibly related? rust-lang/rls#122

I'm using the rls from rustup - maybe it is being compiled with DEV_MODE on?

[KalitaAlexey]

@brendanzab,
If you have time, I would want you to try rls_vscode to check if it is my extension's problem.

[varkor]

Even with revealOutputChannelOn set to "never", VS Code still switches to the output tab whenever I press command while mousing over a non-definition. The setting doesn't seem to have done anything.

[jtremback]

Seems to be an issue in rls_vscode as well. Still a problem though.