Racer error propagated to user

[nrc]

If you get a jump to def error in Racer, we should catch it, not panic.

[nrc]

I believe that we do in fact catch it, but that before catching the panicking thread prints an error message to stderr which appears in the VSCode console. We could install a panic handler to not print the panic, but that would also override the behaviour on the main thread which may or may not be desirable. In any case, the RLS itself does not crash, so I don't think this is super important to fix,

[jonasbb]

Do you mean this message?

Request textDocument/definition failed.
Message: GotoDef failed to complete successfully
Code: -32601

This is not printed on stderr. All stderr is captured in the vscode extension an thrown away. It is caused by this line in action.rs:

out.failure(id, "GotoDef failed to complete successfully");

[nrc]

stderr is not thrown away, you can see it in the console if you switch to the RLS view. I'm talking about the "thread has panicked" + backtrace message.

[jonasbb]

I realized that you are probably running the extension in DEV_MODE.
With DEV_MODE === false the stderr is not shown https://github.com/jonathandturner/rls_vscode/blob/d3978ca62e0106dbc0f07ddc8e4f2801a6cec00d/src/extension.ts#L39