RLS does not install

[Geobert]

Version of VSCode: 1.12.1
Version of the extension: 0.3.14
OS: Win10

Description:
On each launch, I have the infobar poping asking to install RLS, I accept, then it says it need to update rustup, I accept, nothing happens then.

Output of the "Rust logging" channel:rust

DEBUG: Configuration: Rustup: create: sysroot=C:\Users\Geob\.rustup\toolchains\stable-x86_64-pc-windows-msvc
DEBUG: Configuration: Rustup: updateComponents: this.components=["cargo-x86_64-pc-windows-msvc (default)","rust-docs-x86_64-pc-windows-msvc (default)","rust-src (installed)","rust-std-aarch64-apple-ios","rust-std-aarch64-linux-android","rust-std-aarch64-unknown-fuchsia","rust-std-aarch64-unknown-linux-gnu","rust-std-arm-linux-androideabi","rust-std-arm-unknown-linux-gnueabi","rust-std-arm-unknown-linux-gnueabihf","rust-std-arm-unknown-linux-musleabi","rust-std-arm-unknown-linux-musleabihf","rust-std-armv7-apple-ios","rust-std-armv7-linux-androideabi","rust-std-armv7-unknown-linux-gnueabihf","rust-std-armv7-unknown-linux-musleabihf","rust-std-armv7s-apple-ios","rust-std-asmjs-unknown-emscripten","rust-std-i386-apple-ios","rust-std-i586-pc-windows-msvc","rust-std-i586-unknown-linux-gnu","rust-std-i686-apple-darwin","rust-std-i686-linux-android","rust-std-i686-pc-windows-gnu","rust-std-i686-pc-windows-msvc","rust-std-i686-unknown-freebsd","rust-std-i686-unknown-linux-gnu","rust-std-i686-unknown-linux-musl","rust-std-mips-unknown-linux-gnu","rust-std-mips-unknown-linux-musl","rust-std-mips64-unknown-linux-gnuabi64","rust-std-mips64el-unknown-linux-gnuabi64","rust-std-mipsel-unknown-linux-gnu","rust-std-mipsel-unknown-linux-musl","rust-std-powerpc-unknown-linux-gnu","rust-std-powerpc64-unknown-linux-gnu","rust-std-powerpc64le-unknown-linux-gnu","rust-std-s390x-unknown-linux-gnu","rust-std-sparc64-unknown-linux-gnu","rust-std-wasm32-unknown-emscripten","rust-std-x86_64-apple-darwin","rust-std-x86_64-apple-ios","rust-std-x86_64-pc-windows-gnu","rust-std-x86_64-pc-windows-msvc (default)","rust-std-x86_64-rumprun-netbsd","rust-std-x86_64-unknown-freebsd","rust-std-x86_64-unknown-fuchsia","rust-std-x86_64-unknown-linux-gnu","rust-std-x86_64-unknown-linux-musl","rust-std-x86_64-unknown-netbsd","rustc-x86_64-pc-windows-msvc (default)",""]
DEBUG: Configuration: Rustup: updatePathToRlsExecutable: rlsInstalled=false
DEBUG: askPermissionToInstallRls: choice=Install RLS
DEBUG: handleMissingRls: permissionToInstallRlsGranted=true
DEBUG: handleMissingRls: permissionToUpdateRustupGranted=true
DEBUG: handleMissingRls: rustupUpdated=true
DEBUG: handleMissingRls: rlsCanBeInstalled=false
DEBUG: Configuration: updatePathToRacer: findRacerPathSpecifiedByUser: path=undefined
DEBUG: Configuration: updatePathToRacer: findDefaultRacerPath: foundPath=C:\Users\Geob\.cargo\bin\racer.EXE
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): pathDirectories=["C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.10.25017\\bin\\HostX64\\x64\\","C:\\Users\\Geob\\AppData\\Roaming\\Putty\\","C:\\ProgramData\\Oracle\\Java\\javapath","C:\\Windows\\system32","C:\\Windows","C:\\Windows\\System32\\Wbem","C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\","C:\\Program Files (x86)\\Skype\\Phone\\","C:\\Program Files\\Calibre2\\","C:\\WINDOWS\\system32","C:\\WINDOWS","C:\\WINDOWS\\System32\\Wbem","C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\","C:\\Program Files\\OpenVPN\\bin","C:\\Program Files (x86)\\NVIDIA Corporation\\PhysX\\Common","C:\\Users\\Geob\\.cargo\\bin","C:\\Users\\Geob\\AppData\\Local\\Microsoft\\WindowsApps","","C:\\Program Files (x86)\\Microsoft VS Code\\bin"]
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): tools={"racer":"C:\\Users\\Geob\\.cargo\\bin\\racer.EXE","rustfmt":"rustfmt","rustsym":"rustsym"}
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): racer's path=C:\Users\Geob\.cargo\bin\racer.EXE
DEBUG: Legacy Mode Manager: MissingToolsInstallator: getMissingTools(): this.missingTools = []
DEBUG: Legacy Mode Manager: CompletionManager: start: enter
DEBUG: Legacy Mode Manager: CompletionManager: start: racerPath=C:\Users\Geob\.cargo\bin\racer.EXE
DEBUG: Legacy Mode Manager: CompletionManager: start: ENV[RUST_SRC_PATH] = C:\Users\Geob\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src

[Geobert]

Even after manually installing RLS it still says it can't find it (PATH have .cargo/bin inside and RUST_SRC_PATH has been defined)

[Geobert]

I'm new to Rust, so I just discovered how to switch to nightly toolchain by default. RLS is found now, even if it crashes :-/

[KalitaAlexey]

@Geobert,
About crash - #229

[Geobert]

Thanks!

As for this issue, I think that "update rustup" should switch to nightly automatically (with a warning before proceeding)

[KalitaAlexey]

@Geobert,
Actually it is possible to install RLS using the nightly toolchain.
It just needs to be handled.

[KalitaAlexey]

I have no time for this again.

[DanielJoyce]

Right now RLS is so unstable as to be unusable. Currently crashing all the time.

     "rust.rls": {
         "executable": "rustup",
         "args": [
             "run",
             "nightly",
             "rls"
        ]
     }

This needs to go in your vs code settings file.

rustup use stable, but the above settings tell it to use rls under nightly

RLS is so unstable right now I've gone back to racer.

[Enet4]

RLS is so unstable right now I've gone back to racer.

@DanielJoyce It's true that the RLS is not in a stable phase of development. This is precisely what they warn in the front page. Although it usually works and I've been using it myself most of the time, sometimes bugs hit nightly and it might take a few days for the fix to land in the a new release.

Right now, the fix has been made and merged to the main Rust repository. This means that RLS in Rustup should work again tomorrow.

[DanielJoyce]

I expect logic bugs and maybe no editor assistance. The fact the process itself crashes says they're not armoring their service enough. I guess they're using too many plain unwraps() 😜

On Sun, May 14, 2017, 11:02 Eduardo Pinho ***@***.***> wrote: RLS is so unstable right now I've gone back to racer. @DanielJoyce <https://github.com/danieljoyce> It's true that the RLS is not in a stable phase of development. This is precisely what they warn in the front page <https://github.com/rust-lang-nursery/rls#rust-language-server-rls>. Although it usually works and I've been using it myself most of the time, sometimes bugs hit nightly and it might take a few days for the fix to land in the a new release. Right now, the fix has been made and merged to the main Rust repository. This means that RLS in Rustup should work again tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#238 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA50lu_7GrZSrbEiSHBf3mTUVHXsOXuiks5r50GrgaJpZM4NaJyA> .

-- Daniel Joyce The meek shall inherit the Earth, for the brave will be among the stars.

[Enet4]

On this end, it was probably a bad idea to recommend the use of RLS in the documentation, given that it's still in alpha, and prone to instability. Besides, the legacy mode runs fine without losing that many benefits.

[Geobert]

I've tested with toolchain set to nightly and it works in this case :)