Add installing rls #181

KalitaAlexey · 2017-04-18T19:14:21Z

Fixes #177

After this PR:

the documentation will be extended to describe a new way to set RLS up
the extension will:
- determine:
  - if a user uses Rustup
  - if RLS is installed
  - if RLS can be installed via RLS
- ask a user to update Rustup before installing RLS
- ask a user to install RLS
- use RLS installed via Rustup by default (There is no need to specify rust.rls.executable if RLS is installed via Rustup)

For those who wants to try it out:

GitHub documentation
The page "Install the extension from source" in the extension's documentation

git clone https://github.com/editor-rs/vscode-rust.git
cd vscode-rust
git fetch origin pull/181/head:pull-181
git checkout pull-181
npm install
code .

Then Press F5

pronebird · 2017-04-19T13:46:01Z

Since RLS has been added into rustup, it would be awesome to default rust.rls.executable setting to rls. Currently Rust plugin fails to run RLS if this option is not configured. RLS lives now in ~/.cargo/bin/rls.

"rust.rls": {
  "executable": "rls" /* <- should be default */
}

KalitaAlexey · 2017-04-19T13:48:41Z

@pronebird,
Yes, that's what I am doing.

This commit makes the configuration be able to determine if RLS is installed via Rustup and to use it. After this commit a user don't have to specify `rust.rls.executable`, but if one does, a specified value supersedes an automatic one

KalitaAlexey · 2017-04-20T05:17:32Z

@pronebird,
I actually have done what you had asked.
You can try it out.

After this commit on opening any Rust project the extension will ask a user to install RLS if it is not installed yet.

KalitaAlexey · 2017-04-20T20:14:05Z

The next step is to ask a user to install Rustup and to install if the user agrees.
I will make it in another pull request.
Everything works as I planned.

KalitaAlexey · 2017-04-20T20:14:54Z

I ask you to check it.

pronebird · 2017-04-20T21:13:24Z

Hey, thanks a lot for your efforts! I'll test it when I have time and let you know if I spot any issues.

…

Sent from my iPhone

On 20 Apr 2017, at 21:14, Alexey ***@***.***> wrote: I ask you to check it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

KalitaAlexey · 2017-04-21T09:32:37Z

Another next step is to check if a user use stable toolchain and to run RLS using nightly toolchain.
It will be another PR.

pronebird · 2017-04-21T09:41:04Z

@KalitaAlexey I think rustup takes care of that already.

KalitaAlexey · 2017-04-21T10:54:16Z

@pronebird,
I didn't try it, if it does, that's cool)

KalitaAlexey · 2017-04-21T14:13:15Z

A note for:
I must add information about it to the PR

KalitaAlexey · 2017-04-21T17:30:12Z

@redactedscribe,
I need you to review this PR.
Probably some messages can be improved.

pronebird · 2017-04-21T19:07:12Z

I did rustup component remove rls then restarted VSCode with plugin built off this PR. It asked me to install RLS then update rustup. After update RLS has been installed without any problems.

$ rustup component list | grep rls               
rls-x86_64-apple-darwin (installed)

Debug output seems to be correct:

DEBUG: Configuration: Rustup: updatePathToRlsExecutable: RLS is not installed
DEBUG: askForInstallingRlsViaRustup: A user decided to install RLS
DEBUG: handleUserDecisionToInstallRls: A user agreed to update rustup
DEBUG: handleUserDecisionToInstallRls: Rustup has updated successfully
DEBUG: handleUserDecisionToInstallRls: Rustup can install RLS
DEBUG: Configuration: Rustup: updatePathToRlsExecutable: RLS is installed. Path=/Users/pronebird/.cargo/bin/rls
DEBUG: runInRlsMode: env={"RUST_SRC_PATH":"/Users/pronebird/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/"}
DEBUG: runInRlsMode: args=undefined
DEBUG: runInRlsMode: revealOutputChannelOn=4
DEBUG: Language Client Manager: start
DEBUG: Language Client Manager: stop
DEBUG: Language Client Manager: start
DEBUG: Language Client Manager: stop
DEBUG: Language Client Manager: start

KalitaAlexey · 2017-04-21T19:33:53Z

@pronebird,
Did RLS work?

pronebird · 2017-04-21T19:35:07Z

yeah yeah all works!

…

On Apr 21, 2017, at 8:33 PM, Alexey ***@***.***> wrote: @pronebird <https://github.com/pronebird>, Did RLS work? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#181 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAq-LOBV0l-DGeN6vg6MqqdhgAuCXg3Mks5ryQSigaJpZM4NAxaX>.

KalitaAlexey · 2017-04-21T19:50:17Z

@pronebird,
That's nice.

KalitaAlexey · 2017-04-22T07:45:54Z

@pronebird,
rustup does not run RLS when a default toolchain is stable.
rust-lang/rustup#1083

pronebird · 2017-04-22T10:10:35Z

@KalitaAlexey yeah that's not cool :/

pvaibhav · 2017-04-30T22:14:23Z

Thanks for your work. But merging this PR has caused 2 major issues for me:

Every single time I opened VScode I got a message asking me to install RLS because it provides a better user experience. But clicking install asked me to update rustup, clicking update did nothing. This was with stable toolchain (as I guess most users are on).
After I installed nightly toolchain and then rls, every time I start VScode now I get this message: "error: toolchain 'stable-x86_64-apple-darwin' does not have the binary rls"

And none of the completion etc. (that was previously working fine with racer) works anymore.

Was this tested well before release?

What can I do to get rid of the popup after I've removed rls and switched back to stable?

Thanks.

KalitaAlexey · 2017-05-01T05:39:11Z

@pvaibhav,
For your case you can use "forceLegacyMode".
Your case is described in #187

pvaibhav · 2017-05-01T09:31:05Z

Thanks, that brought back the old functionality. Any idea why the new RLS mode doesn't work even after installing rls and switching to nightly?

KalitaAlexey · 2017-05-01T15:27:15Z

@pvaibhav,
It must work.
Open a new issue and attach what the output channel "Rust Logging" shows. Also attach what the output channel "Rust Language Server" shows.

pvaibhav · 2017-05-12T21:52:20Z

@KalitaAlexey sorry for replying late. I managed to get the plugin to try starting in RLS mode after unsetting stable and setting nightly as default. But now I get another error. Logs are below:

Attached the output of "Rust Logging":

DEBUG: Configuration: Rustup: create: sysroot=/Users/pvaibhav/.rustup/toolchains/nightly-x86_64-apple-darwin
DEBUG: Configuration: Rustup: updateComponents: this.components=["cargo-x86_64-apple-darwin (default)","rls-x86_64-apple-darwin (installed)","rust-analysis-x86_64-apple-darwin (installed)","rust-docs-x86_64-apple-darwin (default)","rust-src (installed)","rust-std-aarch64-apple-ios","rust-std-aarch64-linux-android","rust-std-aarch64-unknown-fuchsia","rust-std-aarch64-unknown-linux-gnu","rust-std-arm-linux-androideabi","rust-std-arm-unknown-linux-gnueabi","rust-std-arm-unknown-linux-gnueabihf","rust-std-arm-unknown-linux-musleabi","rust-std-arm-unknown-linux-musleabihf","rust-std-armv7-apple-ios","rust-std-armv7-linux-androideabi","rust-std-armv7-unknown-linux-gnueabihf","rust-std-armv7-unknown-linux-musleabihf","rust-std-armv7s-apple-ios","rust-std-asmjs-unknown-emscripten","rust-std-i386-apple-ios","rust-std-i586-pc-windows-msvc","rust-std-i586-unknown-linux-gnu","rust-std-i686-apple-darwin","rust-std-i686-linux-android","rust-std-i686-pc-windows-gnu","rust-std-i686-pc-windows-msvc","rust-std-i686-unknown-freebsd","rust-std-i686-unknown-linux-gnu","rust-std-i686-unknown-linux-musl","rust-std-mips-unknown-linux-gnu","rust-std-mips-unknown-linux-musl","rust-std-mips64-unknown-linux-gnuabi64","rust-std-mips64el-unknown-linux-gnuabi64","rust-std-mipsel-unknown-linux-gnu","rust-std-mipsel-unknown-linux-musl","rust-std-powerpc-unknown-linux-gnu","rust-std-powerpc64-unknown-linux-gnu","rust-std-powerpc64le-unknown-linux-gnu","rust-std-s390x-unknown-linux-gnu","rust-std-sparc64-unknown-linux-gnu","rust-std-wasm32-unknown-emscripten","rust-std-x86_64-apple-darwin (default)","rust-std-x86_64-apple-ios","rust-std-x86_64-linux-android","rust-std-x86_64-pc-windows-gnu","rust-std-x86_64-pc-windows-msvc","rust-std-x86_64-rumprun-netbsd","rust-std-x86_64-unknown-freebsd","rust-std-x86_64-unknown-fuchsia","rust-std-x86_64-unknown-linux-gnu","rust-std-x86_64-unknown-linux-musl","rust-std-x86_64-unknown-netbsd","rustc-x86_64-apple-darwin (default)",""]
DEBUG: Configuration: Rustup: updatePathToRlsExecutable: rlsInstalled=true
DEBUG: Configuration: Rustup: updatePathToRlsExecutable: rlsPath=/Users/pvaibhav/.cargo/bin/rls
DEBUG: runInRlsMode: rlsPath=/Users/pvaibhav/.cargo/bin/rls
DEBUG: runInRlsMode: env={"RUST_SRC_PATH":"/Users/pvaibhav/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src"}
DEBUG: runInRlsMode: args=[]
DEBUG: runInRlsMode: revealOutputChannelOn=3
DEBUG: Language Client Manager: start

And of "Rust Language Server":

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ErrorImpl { code: Message("missing field `experimental`"), line: 0, column: 0 }', src/libcore/result.rs:859
note: Run with `RUST_BACKTRACE=1` for a backtrace.
[Error - 11:50:14 PM] Connection to server got closed. Server will not be restarted.

How should I run the plugin with RUST_BACKTRACE=1 ?

KalitaAlexey · 2017-05-13T06:22:21Z

Now you experience #229.

KalitaAlexey added 3 commits April 18, 2017 22:02

Removed max-line-length from tslint.json

684a55d

Added a new component File System

e5167c0

Distinguished Rust's installation via Rustup and not via Rustup

8cc172d

KalitaAlexey added the enhancement label Apr 18, 2017

Find RLS installed via Rustup.

256449c

This commit makes the configuration be able to determine if RLS is installed via Rustup and to use it. After this commit a user don't have to specify `rust.rls.executable`, but if one does, a specified value supersedes an automatic one

Ability to update Rustup, to install RLS.

8670e15

After this commit on opening any Rust project the extension will ask a user to install RLS if it is not installed yet.

KalitaAlexey requested a review from redactedscribe April 21, 2017 17:29

Added documentation

12f1f5a

KalitaAlexey merged commit c5c7d2f into master Apr 22, 2017

KalitaAlexey deleted the add-installing-rls branch April 22, 2017 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add installing rls #181

Add installing rls #181

KalitaAlexey commented Apr 18, 2017 •

edited

Loading

pronebird commented Apr 19, 2017 •

edited

Loading

KalitaAlexey commented Apr 19, 2017

KalitaAlexey commented Apr 20, 2017

KalitaAlexey commented Apr 20, 2017

KalitaAlexey commented Apr 20, 2017

pronebird commented Apr 20, 2017 via email

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017 via email

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 22, 2017 •

edited

Loading

pronebird commented Apr 22, 2017

pvaibhav commented Apr 30, 2017

KalitaAlexey commented May 1, 2017

pvaibhav commented May 1, 2017

KalitaAlexey commented May 1, 2017

pvaibhav commented May 12, 2017 •

edited

Loading

KalitaAlexey commented May 13, 2017

Add installing rls #181

Add installing rls #181

Conversation

KalitaAlexey commented Apr 18, 2017 • edited Loading

pronebird commented Apr 19, 2017 • edited Loading

KalitaAlexey commented Apr 19, 2017

KalitaAlexey commented Apr 20, 2017

KalitaAlexey commented Apr 20, 2017

KalitaAlexey commented Apr 20, 2017

pronebird commented Apr 20, 2017 via email

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017

KalitaAlexey commented Apr 21, 2017

pronebird commented Apr 21, 2017 via email

KalitaAlexey commented Apr 21, 2017

KalitaAlexey commented Apr 22, 2017 • edited Loading

pronebird commented Apr 22, 2017

pvaibhav commented Apr 30, 2017

KalitaAlexey commented May 1, 2017

pvaibhav commented May 1, 2017

KalitaAlexey commented May 1, 2017

pvaibhav commented May 12, 2017 • edited Loading

KalitaAlexey commented May 13, 2017

KalitaAlexey commented Apr 18, 2017 •

edited

Loading

pronebird commented Apr 19, 2017 •

edited

Loading

KalitaAlexey commented Apr 22, 2017 •

edited

Loading

pvaibhav commented May 12, 2017 •

edited

Loading