Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

fix racer execution on windows #232

Closed
wants to merge 2 commits into from
Closed

fix racer execution on windows #232

wants to merge 2 commits into from

Conversation

BusyJay
Copy link

@BusyJay BusyJay commented May 10, 2017

close #218

@KalitaAlexey
Copy link
Member

@BusyJay,
I already has some solution.
And it is different.

@KalitaAlexey
Copy link
Member

I have opened #233.
It has some improvements over your solution.
Your code would not work if the user already specified the path surrounded by double quotes.

@BusyJay
Copy link
Author

BusyJay commented May 10, 2017

Actually it will work. As I said in the comment, pathToRacer is stripped by FileSystem.findExecutablePath, the double quote will be stripped away too. So additional check is unnecessary.

@KalitaAlexey
Copy link
Member

@BusyJay,
I'm sorry, but I don't believe anything in JavaScript world.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

racer crash when there is an empty space in path on windows
2 participants
@BusyJay @KalitaAlexey