docs: Rebase to latest main to add language switcher #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coji
changed the title
coji
force-pushed
the
feat/guide-in-ja-JP
branch
from
2a71f01 to
93307ec
Compare
|
@edmundhung I was hoping to be able to do this merge myself, but I don't seem to have the authority to do so. What should I do?
|
|
@coji As we now have the logic to fetch markdown file based on langauge, I think it would be simpler to just have the remix app figuring out the language based on the hostname. I am just adding this logic right now and I will merge the |
edmundhung
force-pushed
the
ja
branch
2 times, most recently
from
9dcf9c0 to
86d71dd
Compare
|
Done. We are now serving the Japanese docs from the main branch as well. |
|
@edmundhung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add language switching to the guide to reflect this PR.
#544