-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make tests OS agnostic #616
chore: make tests OS agnostic #616
Conversation
5187716
to
5dac34b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Should we run the same test suites on window as well? Also, let's not change any package code in this PR.
5dac34b
to
524e433
Compare
0329e2f
to
d15640b
Compare
@edmundhung I'm not sure if its worth it, the E2E tests with MacOS + Windows increase by more than double in terms of execution time, if you want to proceed with it anyway, I'll update to run MacOS again I tried to get Windows to run, but it looks like the playground Remix app doesn't run on windows currently 😅 |
639cd33
to
b106f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue with the folder structure changes. Otherwise looks good to me. Thank you!
We can run them in parallel with GitHub action, right? I am fine to merge it as is but it would definitely be a big plus to be able to test on all 3 platforms. |
74d7fcd
to
ec2e1fa
Compare
0018033
to
afe7117
Compare
afe7117
to
d706880
Compare
@edmundhung this is ready for review now, just need to update the required status checks in GitHub's Settings to the new names |
@edmundhung using sharding in Playwright the total test time has slightly increased by a few seconds, so you won't see too much of a longer wait 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What I did
./tests/integration
as when using VSCode is provides a nice icon to theintegration
folder if using an icon packpnpm
process.env.NODE_ENV === 'production'
to determine if React is running in Strict mode rather thanprocess.env.CI
isStrictMode
closes #379