Update submission.ts

[lifeiscontent]

fixes: #756

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8088117

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

commit: 8088117

@conform-to/dom

pnpm add https://pkg.pr.new/@conform-to/dom@757

@conform-to/react

pnpm add https://pkg.pr.new/@conform-to/react@757

@conform-to/validitystate

pnpm add https://pkg.pr.new/@conform-to/validitystate@757

@conform-to/yup

pnpm add https://pkg.pr.new/@conform-to/yup@757

@conform-to/zod

pnpm add https://pkg.pr.new/@conform-to/zod@757

Open in Stackblitz

More templates

• @conform-example/chakra-ui
• @conform-example/headless-ui
• @conform-example/material-ui
• @conform-example/nextjs
• @conform-example/radix-ui
• @conform-example/react-router
• @conform-example/remix
• @conform-example/shadcn-ui

[lifeiscontent]

@edmundhung I'm not sure if it makes sense to show the error status, but I kept it in because I'm not sure what the expectations are

[lifeiscontent]

@edmundhung I can fix tests if you think this is an appropriate change

[lifeiscontent]

nevermind, I figured out how to do it.

this is the code that works with submission.reply({resetForm: true})

  useEffect(() => {
    if (
      fetcher.state === "idle" &&
      fetcher.data &&
      fetcher.data.status !== "error"
    ) {
      onFinish();
    }
  }, [fetcher.data, fetcher.state, onFinish]);

where onFinish should be called in the scenario you want to close a form drawer.