-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update intent-button.md #761
docs: update intent-button.md #761
Conversation
|
More templates
@conform-to/validitystate
@conform-to/dom
@conform-to/react
@conform-to/yup
@conform-to/zod
commit: |
Hi @KirillSBarsukov, sorry for the confusing example in the docs. If you need to update the value of a field, the minimal setup as of Having said that, the situation is a bit different with our newly released v1.2.0. As it is no longer required to pass a |
Hello @edmundhung , sorry for the late response. I have updated my Conform version to 1.2.2 and can confirm that the example works as expected — almost. I found that the "Add Task" button does not create a new record unless we provide the onSubmit property to the form or destructure the result of the I also included a basic schema to make the code snippet fully functional when copy-pasted. I created this demo for you to try. |
1d47ca8
to
eb841ec
Compare
The change looks right to me! Thanks a lot and sorry for all the confusions. |
One little request, can you help applying the same change on the ja docs? You can find it here https://github.com/edmundhung/conform/blob/main/docs/ja/intent-button.md This is pure code change so we don't need to worry about translations. Thanks again :) |
@edmundhung no worries, it is all good. Updated JP documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Added a working example for insert, remove and reorder intents.