Introduce a new overrideInputs on {default,shell}Nix
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user of this non-flake to have similar functionality
to `follows`.
Example (default.nix):
nix-repl> (import ./.).default
«derivation /nix/store/axgvq22kyb8ymchzq1mjayms4jdl6ni6-ledc-0.1.0.drv»
nix-repl> ((import ./.).overrideInputs { nixpkgs = <nixpkgs>; }).default
«derivation /nix/store/r8zw693hpg91yx6f57hyx1gk4zdiq2lm-ledc-0.1.0.drv»
Accept other forks also with type="github". This is enough to be a bit more convenient in a few more cases once this propagates into new future projects.
lheckemann
approved these changes
Sep 18, 2023
| in "${toString y'}${pad (toString m)}${pad (toString d)}${pad (toString hours)}${pad (toString minutes)}${pad (toString seconds)}"; | ||
|
|
||
| rootOverrides = | ||
| mapAttrs' |
There was a problem hiding this comment.
Any particular reason to use mapAttrs' and not mapAttrs here?
lheckemann
reviewed
Sep 18, 2023
| if key == lockFile.root | ||
| then rootSrc | ||
| else | ||
| if rootOverrides.${key} != null then |
There was a problem hiding this comment.
Suggested change
| if rootOverrides.${key} != null then | |
| if (rootOverrides.${key} or null) != null then |
|
@lheckemann some work continues in https://github.com/ElvishJerricco/flake-compat/tree/add-overrideInputs. i don't currently have the spoons for a review cycle, this may change by next week. if you're looking for this to get merged, it'd probably be wise to make a PR against https://github.com/nix-community/flake-compat 💜 |
|
The current head of the PR is broken, it is missing inputs, no matter if overrideInputs is used or not. The PR at the nix-community flake-compat does work fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user of this non-flake to have similar functionality to
follows.Example (default.nix):
It's currently only able to override our flake's direct inputs. Sorry for the big diff.