Request for adding Chinese UI translation #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there, I'm a chinese user and love this software very much. Thorium is just THE perfect ebook reader for me. So I want to make some contributions for the project and creat this chinese UI translation file, which has passed all the i18n checks in my local repoitory. I'm just a newcomer in Github and hope this will do some help. Best wishes!
Add Simplified Chinese translation
|
Amazing, |
|
@panaC You are welcome! Hope I could do more for the project:) |
|
Hello, I am merging your work into a intermediary branch, so that a few integration issues can be fixed. I will let you know when your work is merged into the develop branch. |
danielweck
added a commit
that referenced
this pull request
Jan 8, 2021
|
All done 👍 #1306 |
|
You are welcome! Anything for the project! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I'm a chinese user and love this software very much. Thorium is just THE perfect ebook reader for me. I am very willing to contribute to the project, so I creat the simplified chinese UI translation file (zh-cn.json) which has passed all the i18n tests in my local repoitory, alongside chinese locale name file (zhCnLang.json) and information file (zh-cn.md). I'm just a newcomer in Github and hope this small work could do some help. Best wishes!