Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SASS implementation: base branch of many Dialog refactor branches #2007

Merged
merged 18 commits into from
Nov 16, 2023
Merged

SASS implementation: base branch of many Dialog refactor branches #2007

merged 18 commits into from
Nov 16, 2023

Conversation

arthur-lemeur
Copy link
Collaborator

No description provided.

@arthur-lemeur arthur-lemeur self-assigned this Sep 25, 2023
@socket-security
Copy link

socket-security bot commented Sep 25, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
node-sass 9.0.0 filesystem, environment +37 5.17 MB xzyfer
sass-loader 13.3.2 environment +38 5.22 MB evilebottnawi

@panaC panaC changed the title test implementation Sass sur Settings.tsx [DEV][WIP]test implementation Sass sur Settings.tsx Oct 6, 2023
@panaC panaC mentioned this pull request Nov 7, 2023
Closed
@panaC
Copy link
Member

panaC commented Nov 7, 2023

This branch is the base of one or (several in future) dialog refactor branches. This PR need to be carefully tested before merge to develop.

@panaC
Copy link
Member

panaC commented Nov 7, 2023

title of the PR 7/11 : [DEV][WIP]test implementation Sass sur Settings.tsx now this PR is the base branch of other refactor branches, the title need to be changed.

@panaC panaC changed the title [DEV][WIP]test implementation Sass sur Settings.tsx [WIP] SASS implementation: base branch of many Dialog refactor branches Nov 7, 2023
@panaC
Copy link
Member

panaC commented Nov 7, 2023

I removed sass exec and move sass-loader and node-sass to dev-deps

@panaC
Copy link
Member

panaC commented Nov 7, 2023

I see that the PR was initially used to test the new sass functionality in the Settings component. Now it's the base branch with sass implementation of other Dialog branches. We need to keep this PR with the minimal change from the develop, just the base sass feature to work with other thorium branches. So I think just keep global css configuration like dark/light theme ?

@arthur-lemeur arthur-lemeur changed the title [WIP] SASS implementation: base branch of many Dialog refactor branches SASS implementation: base branch of many Dialog refactor branches Nov 16, 2023
@arthur-lemeur arthur-lemeur marked this pull request as ready for review November 16, 2023 10:18
@arthur-lemeur arthur-lemeur merged commit 924fb53 into develop Nov 16, 2023
5 checks passed
@danielweck danielweck deleted the arthur/ui/sass1 branch November 16, 2023 10:35
@arthur-lemeur arthur-lemeur restored the arthur/ui/sass1 branch November 16, 2023 10:54
@panaC panaC deleted the arthur/ui/sass1 branch November 23, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck danielweck left review comments

Assignees

@arthur-lemeur arthur-lemeur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthur-lemeur @panaC @danielweck