i18n: enable i18next plurals #2743
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglis
force-pushed
the
enable-i18next-plurals
branch
2 times, most recently
from
9d9995a to
5a794a0
Compare
naglis
force-pushed
the
enable-i18next-plurals
branch
3 times, most recently
from
6168b92 to
3f54390
Compare
naglis
force-pushed
the
enable-i18next-plurals
branch
2 times, most recently
from
ccb79f6 to
365c7cb
Compare
Use the `count` placeholder name for strings which might have different translations depending on the number of results, which enables nicer messages, e.g. "1 match" instead of "1 match(es)". `count` is the reserved placeholder for plural forms used in i18next[1]. Translations can use different suffixes to provide the right messages for all the plural forms applicable to that language. To find out which suffixes should be used for a particular language, this JSFiddle[2] can be used. [1]: https://www.i18next.com/translation-function/plurals [2]: https://jsfiddle.net/6bpxsgd4
naglis
force-pushed
the
enable-i18next-plurals
branch
from
365c7cb to
01bdfe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2660
Use the
countplaceholder name for strings which might have different translations depending on the number of results, which enables nicer messages, e.g. "1 match" instead of "1 match(es)".countis the reserved placeholder for plural forms used in i18next.Translations can use different suffixes to provide the right messages for all the plural forms applicable to that language. To find out which suffixes should be used for a particular language, this JSFiddle can be used.
NOTE: GitLocalize most likely will not support the extra plural forms in different languages, so in order to add/modify them, the translator will have to make PRs. Also,
i18next-json-sync(the CLI tool to extract translatable strings) does not support plural keys (it simply removes them). See #2660 for more information.