Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #626 : multiple import don't stop if an import fail #680

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Fixes #626 : multiple import don't stop if an import fail #680

merged 3 commits into from
Sep 6, 2019

Conversation

Scarsniik
Copy link
Contributor

No description provided.

danielweck
danielweck requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

danielweck
danielweck requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!
Can we please just check null/undefined promise values returned by the import function?

@danielweck danielweck merged commit 5ca7499 into edrlab:develop Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck Awaiting requested review from danielweck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scarsniik @danielweck