-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When items are merged, itemIDs should be written to extra:EdTechHub.ItemAlsoKnownAs #34
Comments
Adding to this: The plugin already merges the archiveLocation/extra:ETHItemAlsoKnownAs fields when items are merged. However, this relies on the items having a populated archiveLocation/extra:ETHItemAlsoKnownAs field. This issue adds the feature that, when items are merged, empty archiveLocation/extra:ETHItemAlsoKnownAs should be populated with the itemsIDs (as if the 'save itemid action was run manually). |
Which branch is this in? |
Not yet on a branch -- this should have been in progress |
🤖 this is your friendly neighborhood build bot announcing test build 0.0.23.226 ("fixes #34") Install in Zotero by downloading test build 0.0.23.226, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
This works! Thanks! However, when I use, 'save item id', a spurious number appears in the item id (which I cannot see in the item metadata). May not be relevant. |
Oh that's the library id. The part before the colon right? That's easy to remove. |
No - on 'save item id', I get this:
So the lib is there as expected, but the There's another problem, which surfaces on 'merge'. If I do 'save item id' first, then I get the merged record as follows:
This is correct, bar the spurious numbers. However, if I do not do 'save item id' first, I get
i.e., I only get the spurious numbers, when the expected result is
|
Updated comment above. Btw. the spurious numbers are consecutive: In another merge op, I got 59846;59847. So it might be some kinda of operation sequence number...? |
🤖 this is your friendly neighborhood build bot announcing test build 0.0.23.229 ("key, not itemID") Install in Zotero by downloading test build 0.0.23.229, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
Ah -- you asked for the itemID, those are numeric. 229 has the item key. |
AHH - apologies! I now get the item key, great! Could you restore the group_id? I.e., at the moment I get
but I want this (with the group_id):
Then please release! Many thanks! |
🤖 this is your friendly neighborhood build bot announcing test build 0.0.23.232 ("lib key + item key") Install in Zotero by downloading test build 0.0.23.232, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
I'd prefer it if you could confirm before I merge it into master |
Sure - let me confirm! |
On 0.0.23.232, I now do not get an entry in extra at all (and no item history). |
There's also an error. With this version, when I use 'save item id', I get 'uri undefined'. |
🤖 this is your friendly neighborhood build bot announcing test build 0.0.23.233 ("something must have changed in the handling of merge") Install in Zotero by downloading test build 0.0.23.233, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...". |
thank you - now works as advertised!! Many thanks - this is very much appreciated! Happy for the latest changes to be released!! |
When items are merged, itemIDs should be saved to extra:ETHItemAlsoKnownAs.
In other words, when items are merged, the same process should take places as when "saving item IDs" from the right-click menu (including checking for old IDs, as per #26).
(Note: Issue #27 should be resolved first.)
The text was updated successfully, but these errors were encountered: