-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For the CC licenses url with country versions #30
base: maven/develop
Are you sure you want to change the base?
For the CC licenses url with country versions #30
Conversation
Signed-off-by: Edmond Kacaj <programim95@gmail.com>
Hello @torsten-simon What about this pull request, is possible to merge and be ready in the next minor/major update of edu-sharing, |
|
It doesn't work and provides wrong result, i.e. a CC-BY licensed element generates this URL in the Metadata Template: Neither the language nor the jurisdiction is provided with a valid value. |
…into fix_license_url
…urrentInstance().getLocale()
Hello @torsten-simon can you have a look? |
Hello @torsten-simon , I've resolved all the conflicts in the merge request, and I believe it's now ready for your review. Could you please take a look and provide your feedback? Thank you! |
Hello @torsten-simon
For the CC licenses with country versions, there is currently an incorrect link displayed on the details pages in Edu-Sharing. There it refers to the "unported" version instead of the country-specific version.
Example: https://www.twillo.de/edu-sharing/components/render/1d1feb01-c412-4c5a-803d-7b90376418ea
Kind regards
Edmond