Codejail REST API service Flask - MVP #2
Conversation
Run configure codejail method before importing safe_exec modules. Adjust settings and wsgi files.
codejailservice/config.py
Outdated
| 'user': 'sandbox', | ||
|
|
||
| # Configurable limits. | ||
| # Setting all of them to 0 to disable limits in conatiners. |
codejailservice/app.py
Outdated
| from copy import deepcopy | ||
| from flask import Flask, Response, jsonify, request | ||
|
|
||
| LOG = logging.getLogger(__name__) |
There was a problem hiding this comment.
The LOG is not used, I imagine you imported it just in case
There was a problem hiding this comment.
If we want to use logging in Flask we need to add the right configuration to get it working right?
There was a problem hiding this comment.
@jfavellar90 Sure, we need to configure it, do you think we should do that in this MVP ?
There was a problem hiding this comment.
I think so, at least a raw version that can be improved afterward.
| @@ -0,0 +1,8 @@ | |||
| import os | |||
There was a problem hiding this comment.
Is this running as a single process in the container? is it possible to use Gunicorn or awsgi? Or is it outside of this MVP?
There was a problem hiding this comment.
In development it runs a single process in the container https://github.com/eduNEXT/tutor-contrib-codejail/blob/b8857457f25f5481a5fdc56d7742f5f6b2420fb9/tutorcodejail/patches/local-docker-compose-dev-services#L2 but in local and k8s it should run using gunicorn
https://github.com/eduNEXT/tutor-contrib-codejail/blob/b8857457f25f5481a5fdc56d7742f5f6b2420fb9/tutorcodejail/templates/codejail/build/codejail/Dockerfile#L79
Are you agree with that @jfavellar90 ?
There was a problem hiding this comment.
I've no problem with Gunicorn but I'm wondering if we should use uwsgi to be consequent with the other tutor services (for instance edxapp )
There was a problem hiding this comment.
It was updated to use uwsgi in local and k8s.
ericfab179
force-pushed
the
eric/mvp_flask
branch
3 times, most recently
from
711711e to
cd90a1a
Compare
ericfab179
changed the title
Fix empty python path case. Basic configuration for logging.
ericfab179
force-pushed
the
eric/mvp_flask
branch
from
cd90a1a to
29d0b18
Compare
felipemontoya
left a comment
felipemontoya
left a comment
There was a problem hiding this comment.
I tested this today using an "august" version of edx-platform with the changes of https://github.com/edx/edx-platform/pull/27795 and it worked as a POC.
I think we should merge this as is and iterate on improving the QA and documentation and fixes that come along as we find them.
Having this in the PR is making it more complicated for people just looking at this now.
4 participants
No description provided.