Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redwood): update templates to support redwood release #221

Merged
merged 3 commits into from
May 23, 2024

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented May 21, 2024

This PR updates the templates according to the upstream redwood release.

Changes

  1. lms/main.html: Provides a fallback for gettext functions in the development environment
  2. lms/coursewere/courses.html: filter courses by user language by default
  3. cms/header.html: Add conditional to display help button in no authenticated user only when it's activated and
  4. Lms/cms update edunext name into help-sidebar.

How to test
Be sure you have eox-tenant and eox-theming in your environment.

Clone the repo in env/build/openedx/themes and be sure to use the current branch dcoa/redwood-support

Add this line in env/build/openedx/settings/lms/assets.py and env/build/openedx/settings/cms/assets.py

COMPREHENSIVE_THEME_DIRS.extend(['/openedx/themes/ednx-saas-themes/edx-platform'])

In the lms.env.yml and cms.env.yml be sure to add:

USE_EOX_TENANT: True
DEFAULT_SITE_THEME: "bragi"
COMPREHENSIVE_THEME_DIRS: ["/openedx/themes/ednx-saas-themes/edx-platform"]

Open bash and compile bragi theme, context
source .tvm/bin/activate
tutor dev run lms bash

# Inside the lms bash 
openedx-assets themes --theme-dirs /openedx/themes/ednx-saas-themes/edx-platform --themes bragi

Now you'll see the default bragi theme applied in all LMS and any error about mako templates. Be sure you don't have selected any bragi-children in the THEME_OPTIONS in the tenant configs

image

https://edunext.atlassian.net/browse/DS-920

@dcoa dcoa changed the title feat: update templates to support redwood release feat(redwood): update templates to support redwood release May 21, 2024
@dcoa dcoa requested review from MaferMazu and bra-i-am May 21, 2024 02:00
Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dcoa dcoa merged commit 620c1d9 into master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants