Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update UI for wiki #222

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: update UI for wiki #222

merged 2 commits into from
Jun 13, 2024

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Jun 13, 2024 •
edited
Loading

This PR

  1. Add Styles to be more accurate with the rest of the UI.
  2. Add the footer template because is not loaded (for the Django templates the function microsite_template_path only searches inside the theme folder)
  3. Fix the button hover text color

image

image

@dcoa dcoa force-pushed the dcoa/fix-styles branch from bec6730 to 9c76cb1 Compare June 13, 2024 11:02
@dcoa dcoa requested review from Alec4r and a team June 13, 2024 11:07
@mariajgrimaldi
Copy link
Contributor

Thank you! Can we deploy this so it's easier to test?

Alec4r
Alec4r previously approved these changes Jun 13, 2024
View reviewed changes
@dcoa
Copy link
Contributor Author

dcoa commented Jun 13, 2024 •
edited
Loading

Sure @mariajgrimaldi ,you can check here https://demo.quince.dedalo.edunext.link/courses/course-v1:demosite+102+00/wiki/demosite.102.00/

https://demo.quince.dedalo.edunext.link/learning/course/course-v1:demosite+102+00/block-v1:demosite+102+00+type@sequential+block@f9985782b7e447c98badae0e3d504ed3/block-v1:demosite+102+00+type@vertical+block@d15a5716e87b4096a22607b58279e7ef (for the submit button)

@dcoa dcoa force-pushed the dcoa/fix-styles branch from 9c76cb1 to 427cf10 Compare June 13, 2024 14:51
mariajgrimaldi
mariajgrimaldi approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thank you!

@dcoa dcoa changed the base branch from edunext/quince.master to edunext/quince.master-LD9fix June 13, 2024 16:38
@dcoa dcoa merged commit 61690a8 into edunext/quince.master-LD9fix Jun 13, 2024
This was referenced Aug 2, 2024
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@Alec4r Alec4r Alec4r left review comments

Assignees

@MaferMazu MaferMazu

@dcoa dcoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcoa @mariajgrimaldi @Alec4r @MaferMazu