Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: no longer use bragi-generator and bragi-childrens (maintaining css-runtime) themes since Nutmeg #232

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jignaciopm
Copy link
Contributor

@jignaciopm jignaciopm commented Nov 14, 2024

Warning

Breaking changes due to removing modules

In this PR the README is created and the themes of the bragi-generator and bragi-childrens modules are removed (keeping css-runtime), since they will not be supported from Nutmeg

@jignaciopm jignaciopm requested a review from a team as a code owner November 14, 2024 17:14
@jignaciopm jignaciopm linked an issue Nov 14, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM the only thing that I consider if is really relevant for the current PR is the README file (Not a blocker but the fact that is a template, worth it?)

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✨
Thanks for this @jignaciopm.

My only comment is that this is not a feat, is a chore change, you can use chore!:...

@jignaciopm jignaciopm changed the title feat!: no longer use bragi-generator and bragi-childrens (maintaining css-runtime) themes since Nutmeg chore!: no longer use bragi-generator and bragi-childrens (maintaining css-runtime) themes since Nutmeg Nov 25, 2024
@jignaciopm jignaciopm merged commit 53c5c6b into master Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPR] Remove the unnecessary themes
3 participants