fix: handle opening verticals in new tabs with the "View In Studio"#618
Merged
mariajgrimaldi merged 1 commit intoedunext/limonero.masterfrom Jan 13, 2022
Merged
Conversation
…utton #24020 introduced a workaround for viewing the current vertical in Studio However, replacing `window.location.href` on `click` did not support opening it in a new tab. (cherry picked from commit 01ada0b)
mariajgrimaldi
requested review from
JuanDavidBuitrago,
MaferMazu,
MoisesGSalas and
johanseto
MoisesGSalas
approved these changes
Jan 13, 2022
JuanDavidBuitrago
approved these changes
Jan 13, 2022
johanseto
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport that fixes redirecting to Course Outline instead of verticals when using open in new page the button "View In Studio"
Additional information
PR in upstream
How to test