backport grant course creation permission#668
Merged
Conversation
Ian2012
requested review from
Alec4r,
DeimerM,
DonatoBD,
felipemontoya and
magajh
Member
|
for context: this work should be merged before the nutmeg migration, but we need to ensure that we do every step in a stable manner. Probably something like this:
|
Ian2012
force-pushed
the
cag/backport-grant-course-creation-permission
branch
from
190a3f7 to
2d768ec
Compare
Current State (before this commit): Studio, as of today doesn't have a way to restrict a user to create a course in a particular organization. What Studio provides right now is a CourseCreator permission which gives an Admin the power to grant a user the permission to create a course. For example: If the Admin has given a user Spiderman the permission to create courses, Spiderman can now create courses in any organization i.e Marvel as well as DC. There is no way to restrict Spiderman from creating courses under DC. Purpose of this commit: The changes done here gives Admin the ability to restrict a user on an Organization level from creating courses via the Course Creators section of the Studio Django administration panel. For example: Now, the Admin can give the user Spiderman the privilege of creating courses only under Marvel organization. The moment Spiderman tries to create a course under some other organization(i.e DC), Studio will show an error message. This change is available to all Studio instances that enable the FEATURES['ENABLE_CREATOR_GROUP'] flag. Regardless of the flag, it will not affect any instances that choose not to use it. BB-3622 (cherry picked from commit 48ad7ef)
Ian2012
force-pushed
the
cag/backport-grant-course-creation-permission
branch
from
af62421 to
72db189
Compare
DonatoBD
approved these changes
Dec 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the functionality of managing course creator permissions from the CourseCreator table which is still kind of compatible with our custom development performed in BC-14 but adds another layer of verification as these changes are only in the backend.
Regarding the frontend there is a PR on upstream to add the selector we currently use.
For this to work, we still need to revert all commits related to our custom development and only let this one. Also, we need to migrate the permissions for courseaccessrole to CourseCreator
Upstream PR