[BD-32] feat: add async feature to Hooks Extension Framework tooling #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajgrimaldi
force-pushed
the
MJG/add_async_feature
branch
from
6f4ac40 to
349ff19
Compare
mariajgrimaldi
commented
Mar 26, 2021
| from .exceptions import HookException | ||
| from .utils import get_functions_for_pipeline | ||
|
|
||
| log = getLogger(__name__) | ||
|
|
||
|
|
||
| @shared_task() |
There was a problem hiding this comment.
Something interesting I found in edx-celeryutils was a BaseTask called LoggedTask, wouldn't be useful to have that extra logging?
mariajgrimaldi
commented
Mar 26, 2021
| @@ -24,7 +24,7 @@ def setUp(self): | |||
| } | |||
| self.pipeline = Mock() | |||
|
|
|||
| @patch("edx_django_utils.hooks.pipeline.get_functions_for_pipeline") | |||
| @patch("edx_django_utils.hooks.tasks.get_functions_for_pipeline") | |||
There was a problem hiding this comment.
here just changing the pipeline location from pipeline.py to tasks.py
mariajgrimaldi
commented
Mar 26, 2021
| log.exception( | ||
| "An error ocurred in trigger_filter while executing `run pipeline` with arguments: %s, %s.", | ||
| str(args), | ||
| str(kwargs), |
There was a problem hiding this comment.
maybe this won't be needed?
There was a problem hiding this comment.
It makes no difference what the pipeline is at this point right?
I mean, we are sure the pipeline object is never the source of this error. It is always the serialization, right?
There was a problem hiding this comment.
Yes, it should always be serialization. I'll add it to the message!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR allows the Hooks Extension Framework: Pipeline (check out its ADR) to run asynchronously using celery tasks.
JIRA:
XXX-XXXX
Dependencies:
This PR depends on Hooks Extension Framework: Tooling
Merge deadline:
None
Testing instructions:
TODO: make test repository usable for aysnc
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: